IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

[dialog-price-edit-db.cpp] plug GList* leaks

Browse Source 
because `namespace_list` and `commodity_list` were being modified in
while loops until they were both nullptr, making g_list_free a
nop. rewrite to plug leaks. also, `list` is a PriceList* which needs
to be gnc_price_unref'd and g_list_freed.
This commit is contained in:
Christopher Lam 2024-04-09 00:25:54 +08:00
parent 233843f151
commit 4f5ee5dc4e
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
gnucash/gnome/dialog-price-edit-db.cpp
View File

@ -244,14 +244,14 @@ gnc_prices_dialog_load_view (GtkTreeView *view, GNCPriceDB *pdb)
const auto commodity_table = gnc_get_current_commodities (); const auto commodity_table = gnc_get_current_commodities ();
auto namespace_list = gnc_commodity_table_get_namespaces (commodity_table); auto namespace_list = gnc_commodity_table_get_namespaces (commodity_table);
while (namespace_list) for (auto node_n = namespace_list; node_n; node_n = g_list_next (node_n))
{ {
auto tmp_namespace = static_cast<char *> (namespace_list->data); auto tmp_namespace = static_cast<char*>(node_n->data);
DEBUG("Looking at namespace %s", tmp_namespace); DEBUG("Looking at namespace %s", tmp_namespace);
auto commodity_list = gnc_commodity_table_get_commodities (commodity_table, tmp_namespace); auto commodity_list = gnc_commodity_table_get_commodities (commodity_table, tmp_namespace);
while (commodity_list) for (auto node_c = commodity_list; node_c; node_c = g_list_next (node_c))
{ {
auto tmp_commodity = static_cast<gnc_commodity *> (commodity_list->data); auto tmp_commodity = static_cast<gnc_commodity*>(node_c->data);
auto num = gnc_pricedb_num_prices (pdb, tmp_commodity); auto num = gnc_pricedb_num_prices (pdb, tmp_commodity);
DEBUG("Looking at commodity %s, Number of prices %d", gnc_commodity_get_fullname (tmp_commodity), num); DEBUG("Looking at commodity %s, Number of prices %d", gnc_commodity_get_fullname (tmp_commodity), num);
@ -276,12 +276,10 @@ gnc_prices_dialog_load_view (GtkTreeView *view, GNCPriceDB *pdb)
g_free (date_str); g_free (date_str);
g_free (num_str); g_free (num_str);
gnc_price_unref (price); g_list_free_full (list, (GDestroyNotify)gnc_price_unref);
} }
commodity_list = g_list_next (commodity_list);
} }
g_list_free (commodity_list); g_list_free (commodity_list);
namespace_list = g_list_next (namespace_list);
} }
g_list_free (namespace_list); g_list_free (namespace_list);