From 5074bd590fdf9604781b1cf193e2f6a40a793d2f Mon Sep 17 00:00:00 2001
From: John Ralls <jralls@ceridwen.us>
Date: Tue, 26 Jul 2016 13:28:22 -0700
Subject: [PATCH] Don't leak the quoted string returned from
 dbi_conn_quote_string_copy.

---
 src/backend/dbi/gnc-dbisqlconnection.cpp | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/src/backend/dbi/gnc-dbisqlconnection.cpp b/src/backend/dbi/gnc-dbisqlconnection.cpp
index aa53d6a349..c866cb5069 100644
--- a/src/backend/dbi/gnc-dbisqlconnection.cpp
+++ b/src/backend/dbi/gnc-dbisqlconnection.cpp
@@ -414,14 +414,11 @@ GncDbiSqlConnection::quote_string (const std::string& unquoted_str)
 
     size = dbi_conn_quote_string_copy (m_conn, unquoted_str.c_str(),
                                        &quoted_str);
-    if (size != 0)
-    {
-        return std::string{quoted_str};
-    }
-    else
-    {
+    if (quoted_str == nullptr)
         return std::string{""};
-    }
+    std::string retval{quoted_str};
+    free(quoted_str);
+    return retval;
 }