IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

[import-backend] don't search GHashTable twice

Browse Source 
search acct_id_hash once for dest_acct
This commit is contained in:
Christopher Lam
2023-02-07 23:59:36 +08:00
parent bf79d6fa58
commit 50e9e70592
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
gnucash/import-export/import-backend.cpp
View File

@@ -1017,12 +1017,16 @@ gboolean gnc_import_exists_online_id (Transaction *trans, GHashTable* acct_id_ha
// Create a hash per account of a hash of all split IDs. Then the // Create a hash per account of a hash of all split IDs. Then the
// test below will be fast if we have many transactions to import. // test below will be fast if we have many transactions to import.
auto dest_acct = xaccSplitGetAccount (source_split); auto dest_acct = xaccSplitGetAccount (source_split);
if (!g_hash_table_contains (acct_id_hash, dest_acct))
g_hash_table_insert (acct_id_hash, dest_acct, auto online_id_hash = static_cast<GHashTable*>(g_hash_table_lookup (acct_id_hash, dest_acct));
hash_account_online_ids (dest_acct));
auto online_id_exists = g_hash_table_contains ( if (!online_id_hash)
static_cast<GHashTable*>(g_hash_table_lookup (acct_id_hash, dest_acct)), {
source_online_id); online_id_hash = hash_account_online_ids (dest_acct);
g_hash_table_insert (acct_id_hash, dest_acct, online_id_hash);
}
auto online_id_exists = g_hash_table_contains (online_id_hash, source_online_id);
/* If it does, abort the process for this transaction, since it is /* If it does, abort the process for this transaction, since it is
already in the system. */ already in the system. */