From 512dd7c73cd86fe6f9beef71ee66f11b70c68846 Mon Sep 17 00:00:00 2001
From: Christopher Lam <christopher.lck@gmail.com>
Date: Thu, 30 Aug 2018 22:29:55 +0800
Subject: [PATCH] [report-utilities] compact
 gnc:get-account-period-rolledup-budget-value

---
 .../report/report-system/report-utilities.scm | 29 ++++++-------------
 1 file changed, 9 insertions(+), 20 deletions(-)

diff --git a/gnucash/report/report-system/report-utilities.scm b/gnucash/report/report-system/report-utilities.scm
index 00ef51e6e0..3ffaeb9fd9 100644
--- a/gnucash/report/report-system/report-utilities.scm
+++ b/gnucash/report/report-system/report-utilities.scm
@@ -980,18 +980,10 @@
 ;; Return value:
 ;;   budget value to use for account for specified period.
 (define (budget-account-sum budget children period)
-  (let* ((sum
-           (cond
-             ((null? children) (gnc-numeric-zero))
-             (else
-               (gnc-numeric-add
-                 (gnc:get-account-period-rolledup-budget-value budget (car children) period)
-                 (budget-account-sum budget (cdr children) period)
-                 GNC-DENOM-AUTO GNC-RND-ROUND))
-               )
-        ))
-  sum)
-)
+  (apply + (map
+            (lambda (child)
+              (gnc:get-account-period-rolledup-budget-value budget child period))
+            children)))
 
 ;; Calculate the value to use for the budget of an account for a specific period.
 ;; - If the account has a budget value set for the period, use it
@@ -1007,14 +999,11 @@
 ;;   sum of all budgets for list of children for specified period.
 (define (gnc:get-account-period-rolledup-budget-value budget acct period)
   (let* ((bgt-set? (gnc-budget-is-account-period-value-set budget acct period))
-        (children (gnc-account-get-children acct))
-        (amount (cond
-                  (bgt-set? (gnc-budget-get-account-period-value budget acct period))
-          ((not (null? children)) (budget-account-sum budget children period))
-          (else (gnc-numeric-zero)))
-        ))
-  amount)
-)
+         (children (gnc-account-get-children acct)))
+    (cond
+     (bgt-set? (gnc-budget-get-account-period-value budget acct period))
+     ((not (null? children)) (budget-account-sum budget children period))
+     (else 0))))
 
 ;; Sums rolled-up budget values for a single account from start-period (inclusive) to
 ;; end-period (exclusive).