From 54d0a535ab5abe2d0910d990e9e2788412d73450 Mon Sep 17 00:00:00 2001 From: Simon Arlott Date: Fri, 23 Jun 2023 17:18:05 +0100 Subject: [PATCH] [gnc-main-window] Fix null pointer dereference when opening existing pages When the page already exists in a window then we can't be restoring pages so stop checking. The "window" variable will be nullptr if we're trying to open the page "in any window". This bug was introduced in the changes for bug 798564. --- gnucash/gnome-utils/gnc-main-window.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gnucash/gnome-utils/gnc-main-window.cpp b/gnucash/gnome-utils/gnc-main-window.cpp index ea2a3f0239..25eb9460bc 100644 --- a/gnucash/gnome-utils/gnc-main-window.cpp +++ b/gnucash/gnome-utils/gnc-main-window.cpp @@ -3189,8 +3189,7 @@ gnc_main_window_open_page (GncMainWindow *window, if (gnc_main_window_page_exists(page)) { - if (!gnc_main_window_is_restoring_pages (window)) - gnc_main_window_display_page (page); + gnc_main_window_display_page (page); return; }