From 571450099017e8ec36476e5e04007791fa8feeb7 Mon Sep 17 00:00:00 2001 From: Christian Stimming Date: Tue, 27 Jun 2006 09:10:29 +0000 Subject: [PATCH] Ignore failed chown() because it always fails on vfat/samba. #345913 git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@14452 57a11ea4-9604-0410-9ed3-97b8803252fd --- ChangeLog | 5 +++++ src/backend/file/gnc-backend-file.c | 12 ++++++------ 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/ChangeLog b/ChangeLog index 1c98c0e206..10f258edb9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2006-06-27 Christian Stimming + + * src/backend/file/gnc-backend-file.c: Ignore failed chown() + because it always fails on vfat/samba. #345913 + 2006-06-26 David Hampton * src/pixmaps/gnucash-icon.png: diff --git a/src/backend/file/gnc-backend-file.c b/src/backend/file/gnc-backend-file.c index b094c87cec..0d437a2e32 100644 --- a/src/backend/file/gnc-backend-file.c +++ b/src/backend/file/gnc-backend-file.c @@ -519,18 +519,18 @@ gnc_file_be_write_to_file(FileBackend *fbe, /* Use the permissions from the original data file */ if(chmod(tmp_name, statbuf.st_mode) != 0) { - qof_backend_set_error(be, ERR_BACKEND_PERM); - /* FIXME: Even if the chmod did fail, the save + /* qof_backend_set_error(be, ERR_BACKEND_PERM); */ + /* Even if the chmod did fail, the save nevertheless completed successfully. It is therefore wrong to signal the ERR_BACKEND_PERM error here which implies that the saving itself - failed! What should we do? */ + failed. Instead, we simply ignore this. */ PWARN("unable to chmod filename %s: %s", tmp_name ? tmp_name : "(null)", strerror(errno) ? strerror(errno) : ""); -#if VFAT_DOESNT_SUCK /* chmod always fails on vfat fs */ - g_free(tmp_name); - return FALSE; +#if VFAT_DOESNT_SUCK /* chmod always fails on vfat/samba fs */ + /* g_free(tmp_name); */ + /* return FALSE; */ #endif } #ifdef HAVE_CHOWN