IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

[gnc-report.cpp] Refinement to 1da2464577 -- *errmsg must be assigned

Browse Source 
Callers to this function expect that either *data or *errmsg are
assigned a newly allocated char, to be g_freed later.
This commit is contained in:
Christopher Lam 2023-12-21 22:05:11 +08:00
parent cac01aae65
commit 5bcf979f0b
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
gnucash/report/gnc-report.cpp
View File

@ -227,18 +227,12 @@ gnc_run_report_with_error_handling (gint report_id, gchar ** data, gchar **errms
*errmsg = NULL; *errmsg = NULL;
return TRUE; return TRUE;
} }
else if (scm_is_string (captured_error))
{
*errmsg = gnc_scm_to_utf8_string (captured_error);
*data = NULL;
PWARN ("Error in report: %s", *errmsg);
return FALSE;
}
else else
{ {
*errmsg = scm_is_string (captured_error) ? gnc_scm_to_utf8_string (captured_error) :
g_strdup ("");
*data = nullptr; *data = nullptr;
PWARN("Report %s Failed to generate html but didn't raise a Scheme exception.", PWARN ("Error in report: %s", *errmsg);
gnc_report_name (report));
return FALSE; return FALSE;
} }
} }