IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Ensure incorrectly coded counter KVP is read correctly.

Browse Source 
Bug 798930 caused some counters to be saved as KVP double. If the
correct int64_t value isn't found when reading, or if a double is
encountered when loading the option dialog, get the double value
and cast it to int64_t.
This commit is contained in:
John Ralls
2023-05-26 21:24:06 -04:00
parent 7d5663899c
commit 6111184c73
2 changed files with 23 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
libgnucash/engine/gnc-optiondb.cpp
View File

@@ -512,10 +512,25 @@ GncOptionDB::load_from_kvp(QofBook* book) noexcept
auto kvp = qof_book_get_option(book, &list_head);
if (!kvp)
return;
auto set_double = [&option, kvp, &list_head]() {
/*counters might have been set as doubles
* because of
* https://bugs.gnucash.org/show_bug.cgi?id=798930. They
* should be int64_t.
*/
constexpr const char *counters{"counters"};
auto value{kvp->get<double>()};
if (strcmp(static_cast<char*>(list_head.data), counters) == 0)
option.set_value(static_cast<int64_t>(value));
else
option.set_value(value);
};
switch (kvp->get_type())
{
case KvpValue::Type::DOUBLE:
option.set_value(kvp->get<double>());
set_double();
break;
case KvpValue::Type::INT64:
option.set_value(kvp->get<int64_t>());