Miscellaneous KVP cleanup.

Everything but the backends and app-utils.

src/gnome-utils/dialog-preferences.c

@@ -1062,7 +1062,6 @@ gnc_preferences_dialog_create(void)
     gnc_commodity *locale_currency;
     const gchar *currency_name;
     QofBook *book;
-    KvpFrame *book_frame;
     gint64 month, day;
     GDate fy_end;
     gboolean date_is_valid = FALSE;

src/gnome-utils/gnc-tree-view-owner.c

@@ -954,16 +954,16 @@ owner_cell_kvp_data_func (GtkTreeViewColumn *tree_column,
                           gpointer key)
 {
     GncOwner *owner;
-    kvp_frame * frame;
+    GValue v = G_VALUE_INIT;
 
     g_return_if_fail (GTK_IS_TREE_MODEL_SORT (s_model));
     owner = gnc_tree_view_owner_get_owner_from_iter(s_model, s_iter);
-    frame = gncOwnerGetSlots(owner);
-
-    g_object_set (G_OBJECT (cell),
-                  "text", kvp_frame_get_string(frame, (gchar *)key),
-                  "xalign", 0.0,
-                  NULL);
+    qof_instance_get_kvp (QOF_INSTANCE (owner), (gchar*)key, &v);
+    if (G_VALUE_HOLDS_STRING)
+         g_object_set (G_OBJECT (cell),
+                       "text", g_value_get_string (&v),
+                       "xalign", 0.0,
+                       NULL);
 
 }
 

src/import-export/import-account-matcher.c

@@ -76,7 +76,7 @@ static AccountPickerDialog* gnc_import_new_account_picker(void)
 /**************************************************
  * test_acct_online_id_match
  *
- * test for match of kvp_frame of account
+ * test for match of account online_ids.
  **************************************************/
 static gpointer test_acct_online_id_match(Account *acct, gpointer param_online_id)
 {

src/import-export/import-account-matcher.h

@@ -52,11 +52,11 @@ typedef struct
 } AccountPickerDialog;
 
 /**  Must be called with a string containing a unique identifier for the
-  account.  If an account with a matching online_id kvp_frame is
+  account.  If an account with a matching online_id is
   found, the function immediately returns with a pointer to that
   account.  Otherwise, the user is prompted to select a GnuCash
   account or create a new one (in both cases, the unique identifier is
-  written to the account's kvp_frame, so the user won't be prompted
+  written to the account, so the user won't be prompted
   again).  If the user refuses to select or create an account, NULL is
   returned.
 
@@ -70,7 +70,7 @@ typedef struct
     selector that allows you to select an account whose GncGUID will be
     remembered elsewhere.  You would fill account_human_description to tell
     the user what he is looking for.  In this mode, the  online_id
-    kvp_frame of the found account will not be touched.  To use this mode,
+    field of the found account will not be touched.  To use this mode,
     auto_create must NOT be set to 0.
 
     @param account_human_description
@@ -136,7 +136,7 @@ AccountPickerDialog * gnc_import_account_assist_setup (GtkWidget *parent);
 
 
 /**  Must be called with an AccountPickerDialog structure allready setup.
-     If an account with a matching online_id kvp_frame is found, which is
+     If an account with a matching online_id is found, which is
      allready present in the dialog structure, the function returns with a
      pointer to that account or NULL if not found.
 

src/import-export/import-backend.c

@@ -1116,7 +1116,7 @@ gnc_import_process_trans_item (GncImportMatchMap *matchmap,
 /********************************************************************\
  * check_trans_online_id() Callback function used by
  * gnc_import_exists_online_id.  Takes pointers to transaction and split,
- * returns 0 if their online_id kvp_frames do NOT match, or if the split
+ * returns 0 if their online_ids  do NOT match, or if the split
  * belongs to the transaction
 \********************************************************************/
 static gint check_trans_online_id(Transaction *trans1, void *user_data)

src/import-export/import-utilities.h

@@ -40,7 +40,7 @@
 #include "Account.h"
 
 /** @name Setter-getters
-    Setter and getter functions for the online_id kvp_frame for
+    Setter and getter functions for the online_id field for
     Accounts.
 	@{
 */
@@ -49,7 +49,7 @@ void gnc_import_set_acc_online_id(Account * account,
                                   const gchar * string_value);
 /** @} */
 /** @name Setter-getters
-    Setter and getter functions for the online_id kvp_frame for
+    Setter and getter functions for the online_id field for
     Transactions.
 	@{
 */
@@ -61,7 +61,7 @@ void gnc_import_set_trans_online_id(Transaction * transaction,
 gboolean gnc_import_trans_has_online_id(Transaction * transaction);
 
 /** @name Setter-getters
-    Setter and getter functions for the online_id kvp_frame for
+    Setter and getter functions for the online_id field for
     Splits.
 	@{
 */

src/register/ledger-core/split-register-model-save.c

@@ -660,7 +660,6 @@ gnc_template_register_save_xfrm_cell (BasicCell * cell,
     SRInfo *info = gnc_split_register_get_info (reg);
     Account *template_acc;
     const GncGUID *acctGUID;
-    KvpFrame *kvpf;
     Account *acct;
 
     g_return_if_fail (gnc_basic_cell_has_name (cell, XFRM_CELL));