IntenseFinance/gnucash
3
0 Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2026-10-25 23:50:06 -05:00
Code Issues Packages Projects Releases Wiki Activity

Change g_assert() -> g_assert_true() in tests

Browse Source 
g_assert() can be compiled out, so should not be used for tests

g_assert_true was removed
to fis https://bugs.gnucash.org/show_bug.cgi?id=792008 because
g_assert_true was introduced in glib-2.38 and at the time GnuCash required
only glib-2.26. GnuCash has required glib >= 2.40 since 8acbc41c6 so
g_assert_true can be restored.
This commit is contained in:
Richard Cohen authored and John Ralls committed 2023-07-16 10:09:12 -07:00
1 parent 59be6f4974
commit 66c5e398ae
26 files changed
+1339 -1339
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

libgnucash/backend/sql/test/utest-gnc-backend-sql.cpp
+13 -13
View File
@@ -258,7 +258,7 @@ gnc_sql_commit_edit (GncSqlBackend *sql_be, QofInstance *inst)// C: 1 */
static void
test_dirty_cb (QofBook* book, gboolean dirty, gpointer data)
{
g_assert (data != NULL);
g_assert_true (data != NULL);
if (dirty)
++* (guint*)data;
else if (* (guint*)data)
@@ -296,34 +296,34 @@ test_gnc_sql_commit_edit (void)
gnc_account_create_root (book);
qof_book_mark_session_dirty (book);
g_assert (qof_instance_get_dirty_flag (inst));
g_assert (qof_book_session_not_saved (book));
g_assert_true (qof_instance_get_dirty_flag (inst));
g_assert_true (qof_book_session_not_saved (book));
g_assert_cmpint (dirty_called, == , 1);
sql_be->commit(inst);
g_assert (!qof_instance_get_dirty_flag (inst));
g_assert (!qof_book_session_not_saved (book));
g_assert_true (!qof_instance_get_dirty_flag (inst));
g_assert_true (!qof_book_session_not_saved (book));
g_assert_cmpint (dirty_called, == , 0);
g_assert_cmpint (check1.hits, == , 2);
qof_book_mark_session_dirty (book);
g_assert (!qof_instance_get_dirty_flag (QOF_INSTANCE (book)));
g_assert (qof_book_session_not_saved (book));
g_assert_true (!qof_instance_get_dirty_flag (QOF_INSTANCE (book)));
g_assert_true (qof_book_session_not_saved (book));
g_assert_cmpint (dirty_called, == , 1);
sql_be->commit(QOF_INSTANCE (book));
g_assert (!qof_instance_get_dirty_flag (QOF_INSTANCE (book)));
g_assert (qof_book_session_not_saved (book));
g_assert_true (!qof_instance_get_dirty_flag (QOF_INSTANCE (book)));
g_assert_true (qof_book_session_not_saved (book));
g_assert_cmpint (dirty_called, == , 1);
g_assert_cmpint (check1.hits, == , 2);
qof_instance_set_dirty_flag (QOF_INSTANCE (book), TRUE);
g_assert (qof_instance_get_dirty_flag (QOF_INSTANCE (book)));
g_assert (qof_book_session_not_saved (book));
g_assert_true (qof_instance_get_dirty_flag (QOF_INSTANCE (book)));
g_assert_true (qof_book_session_not_saved (book));
g_assert_cmpint (dirty_called, == , 1);
sql_be->commit(QOF_INSTANCE (book));
g_assert (!qof_instance_get_dirty_flag (QOF_INSTANCE (book)));
g_assert (!qof_book_session_not_saved (book));
g_assert_true (!qof_instance_get_dirty_flag (QOF_INSTANCE (book)));
g_assert_true (!qof_book_session_not_saved (book));
g_assert_cmpint (dirty_called, == , 0);
g_assert_cmpint (check1.hits, == , 2);