IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-20 11:48:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

transaction voiding now tested and works :)

Browse Source 
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@5469 57a11ea4-9604-0410-9ed3-97b8803252fd
This commit is contained in:
Robert Graham Merkel 2001-10-08 05:20:27 +00:00
parent 2408e0f983
commit 67849a74ca
4 changed files with 23 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
ChangeLog
View File

@ -1,3 +1,13 @@
2001-10-08 Robert Graham Merkel <rgmerk@mira.net>
* src/engine/test/test-transaction-voiding.c (run_test): remove
diagnostic stuff needed for initial debugging, fix bug in test.
* src/engine/Transaction.c: removed transaction void debugging
stuff.
* src/engine/test/Makefile.am: enable transaction voiding test.
2001-10-05 Robert Graham Merkel <rgmerk@mira.net> 2001-10-05 Robert Graham Merkel <rgmerk@mira.net>
* src/engine/test/test-transaction-voiding.c: new file. * src/engine/test/test-transaction-voiding.c: new file.
@ -25,8 +35,9 @@
* src/engine/gw-engine-spec.scm: wrap voiding functions * src/engine/gw-engine-spec.scm: wrap voiding functions
* src/report/report-system/report-utilities.scm: added some convenience functions * src/report/report-system/report-utilities.scm: added some
for adding voiding checks to queries and checking the voiding status of splits. convenience functions for adding voiding checks to queries and
checking the voiding status of splits.
* src/report/standard-reports/*: fixed up queries to exclude voids as appropriate. * src/report/standard-reports/*: fixed up queries to exclude voids as appropriate.

11
src/engine/Transaction.c
View File

@ -2633,16 +2633,7 @@ xaccTransVoid(Transaction *transaction,
xaccTransCommitEdit(transaction); xaccTransCommitEdit(transaction);
for(split_list = xaccTransGetSplitList(transaction);
split_list;
split_list = g_list_next(split_list))
{
char *string = gnc_numeric_to_string(xaccSplitGetAmount(split_list->data));
fprintf(stderr, "%s\n", string);
g_free(string);
}
return; return;
} }

8
src/engine/test/Makefile.am
View File

@ -25,8 +25,8 @@ TESTS = \
test-group-vs-book \ test-group-vs-book \
test-resolve-file-path \ test-resolve-file-path \
test-scm-query \ test-scm-query \
test-split-vs-account test-split-vs-account \
# test-transaction-voiding test-transaction-voiding
TESTS_ENVIRONMENT = \ TESTS_ENVIRONMENT = \
GNC_MODULE_PATH="${top_srcdir}/src/engine" \ GNC_MODULE_PATH="${top_srcdir}/src/engine" \
@ -41,8 +41,8 @@ bin_PROGRAMS = \
test-load-engine \ test-load-engine \
test-resolve-file-path \ test-resolve-file-path \
test-scm-query \ test-scm-query \
test-split-vs-account test-split-vs-account \
# test-transaction-voiding test-transaction-voiding
EXTRA_DIST = \ EXTRA_DIST = \
test-create-account \ test-create-account \

15
src/engine/test/test-transaction-voiding.c
View File

@ -38,7 +38,7 @@ run_test (void)
Account *acc1, *acc2; Account *acc1, *acc2;
Transaction *transaction; Transaction *transaction;
gnc_numeric old_amt, new_amt, new_kvp_amt, old_val, new_val, new_kvp_val; gnc_numeric old_amt, new_amt, new_kvp_amt, old_val, new_val, new_kvp_val;
int rval;
GNCSession *session; GNCSession *session;
char *reason = "because I can"; char *reason = "because I can";
@ -64,9 +64,6 @@ run_test (void)
old_amt = xaccSplitGetAmount(xaccTransGetSplit(transaction, 0)); old_amt = xaccSplitGetAmount(xaccTransGetSplit(transaction, 0));
old_val = xaccSplitGetValue(xaccTransGetSplit(transaction, 1)); old_val = xaccSplitGetValue(xaccTransGetSplit(transaction, 1));
print_gnc_numeric(old_amt);
print_gnc_numeric(old_val);
getchar();
xaccTransVoid(transaction, reason); xaccTransVoid(transaction, reason);
@ -87,25 +84,23 @@ run_test (void)
if (!gnc_numeric_zero_p( new_amt)) if (!gnc_numeric_zero_p( new_amt))
{ {
fprintf(stderr, "%s\n", gnc_numeric_to_string(new_amt));
failure("Amount not zero after voiding"); failure("Amount not zero after voiding");
} }
new_val = xaccSplitGetValue(xaccTransGetSplit(transaction, 1)); new_val = xaccSplitGetValue(xaccTransGetSplit(transaction, 1));
print_gnc_numeric(new_val);
if (!gnc_numeric_zero_p(new_val)); if (!(gnc_numeric_zero_p(new_val)))
{ {
fprintf(stderr, "%s\n", gnc_numeric_to_string(new_val));
failure("Amount not zero after voiding"); failure("Amount not zero after voiding");
} }
if(!gnc_numeric_eq(old_amt, xaccSplitVoidFormerAmount(xaccTransGetSplit(transaction, 0)))) if(!(gnc_numeric_eq(old_amt, xaccSplitVoidFormerAmount(xaccTransGetSplit(transaction, 0)))))
{ {
failure("former amount (after voiding) didn't match actual old amount"); failure("former amount (after voiding) didn't match actual old amount");
} }
if(!gnc_numeric_eq(old_val, xaccSplitVoidFormerValue(xaccTransGetSplit(transaction, 1)))) if(!(gnc_numeric_eq(old_val, xaccSplitVoidFormerValue(xaccTransGetSplit(transaction, 1)))))
{ {
failure("former value (after voiding) didn't match actual old value"); failure("former value (after voiding) didn't match actual old value");
} }