IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

New clang error enforces virtual destructors.

Browse Source
This commit is contained in:
John Ralls 2018-06-22 09:09:13 -07:00
parent 32e7994843
commit 696277bbf6
3 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
gnucash/import-export/csv-imp/gnc-imp-settings-csv.hpp
View File

@ -55,6 +55,7 @@ struct CsvImportSettings
m_date_format {0}, m_currency_format {0},
m_skip_start_lines{0}, m_skip_end_lines{0}, m_skip_alt_lines (false),
m_separators {","}, m_load_error {false} { }
virtual ~CsvImportSettings() = default;
/** Save the gathered widget properties to a key File.
*

4
libgnucash/backend/sql/gnc-sql-column-table-entry.hpp
View File

@ -140,6 +140,7 @@ public:
m_flags{static_cast<ColumnFlags>(f)},
m_gobj_param_name{gobj_name}, m_qof_param_name{qof_name}, m_getter{get},
m_setter{set} {}
virtual ~GncSqlColumnTableEntry() = default;
/**
* Load a value into an object from the database row.
@ -254,7 +255,7 @@ private:
};
template <GncSqlObjectType Type>
class GncSqlColumnTableEntryImpl : public GncSqlColumnTableEntry
class GncSqlColumnTableEntryImpl final : public GncSqlColumnTableEntry
{
public:
GncSqlColumnTableEntryImpl (const char* name, const GncSqlObjectType type,
@ -265,6 +266,7 @@ public:
QofSetterFunc set = nullptr) :
GncSqlColumnTableEntry (name, type, s, f, gobj_name,qof_name, get, set)
{}
void load(const GncSqlBackend* sql_be, GncSqlRow& row, QofIdTypeConst obj_name,
void* pObject) const noexcept override;
void add_to_table(ColVec& vec) const noexcept override;

1
libgnucash/backend/sql/gnc-sql-object-backend.hpp
View File

@ -54,6 +54,7 @@ public:
const std::string& table, const EntryVec& vec) :
m_table_name{table}, m_version{version}, m_type_name{type},
m_col_table(vec) {}
virtual ~GncSqlObjectBackend() = default;
/**
* Load all objects of m_type in the database into memory.
* @param sql_be The GncSqlBackend containing the database connection.