From 6bcd69026b6c09ead4ac1daad461a960f8dd362b Mon Sep 17 00:00:00 2001 From: Christopher Lam Date: Tue, 19 Oct 2021 19:12:33 +0800 Subject: [PATCH] [gnc-budget-view] avoid O(N^2) g_list_length calls --- gnucash/gnome/gnc-budget-view.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnucash/gnome/gnc-budget-view.c b/gnucash/gnome/gnc-budget-view.c index 0516ff0542..c9a1e46720 100644 --- a/gnucash/gnome/gnc-budget-view.c +++ b/gnucash/gnome/gnc-budget-view.c @@ -1590,7 +1590,7 @@ gnc_budget_view_refresh (GncBudgetView *budget_view) col = GTK_TREE_VIEW_COLUMN((g_list_last (col_list))->data); gtk_tree_view_remove_column (GTK_TREE_VIEW(priv->tree_view), col); col_list = g_list_delete_link (col_list, g_list_last (col_list)); - num_periods_visible = g_list_length (col_list); + num_periods_visible--; col = GTK_TREE_VIEW_COLUMN(totals_col_list->data); gtk_tree_view_remove_column (GTK_TREE_VIEW(priv->totals_tree_view), col); @@ -1653,7 +1653,7 @@ gnc_budget_view_refresh (GncBudgetView *budget_view) totals_col_list = g_list_prepend (totals_col_list, col); } - num_periods_visible = g_list_length (col_list); + num_periods_visible++; } gdk_rgba_free (note_color);