IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

* src/register/ledger-core/split-register-model-save.c: when

Browse Source 
editing an exchange rate, always change the _VALUE_ of the
	  split, not the amount.  This has the affect of keeping the
	  visible number the same and changing the "other" account.  This
	  should fix #102161


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@7784 57a11ea4-9604-0410-9ed3-97b8803252fd
This commit is contained in:
Derek Atkins 2003-01-06 04:29:15 +00:00
parent b5641d333c
commit 6d8034012d
2 changed files with 29 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ChangeLog
View File

@ -29,7 +29,13 @@
through the list and 'select' those that are marked as "start selected" through the list and 'select' those that are marked as "start selected"
* accounts/C/acctchrt_common.gnucash-xea: mark this account tree as * accounts/C/acctchrt_common.gnucash-xea: mark this account tree as
"start selected" "start selected"
* src/register/ledger-core/split-register-model-save.c: when
editing an exchange rate, always change the _VALUE_ of the
split, not the amount. This has the affect of keeping the
visible number the same and changing the "other" account. This
should fix #102161
2003-01-04 David Hampton <hampton@employees.org> 2003-01-04 David Hampton <hampton@employees.org>
* src/backend/file/gnc-account-xml-v2.c: * src/backend/file/gnc-account-xml-v2.c:

37
src/register/ledger-core/split-register-model-save.c
View File

@ -380,21 +380,11 @@ gnc_split_register_split_needs_amount (SplitRegister *reg, Split *split)
} }
static void static void
gnc_split_register_save_debcred_cell (BasicCell * bcell, gnc_split_register_save_amount_values (SRSaveData *sd, SplitRegister *reg)
gpointer save_data,
gpointer user_data)
{ {
SRSaveData *sd = save_data;
SplitRegister *reg = user_data;
Account *acc; Account *acc;
gnc_numeric new_amount, convrate, amtconv, value; gnc_numeric new_amount, convrate, amtconv, value;
g_return_if_fail (gnc_basic_cell_has_name (bcell, DEBT_CELL) ||
gnc_basic_cell_has_name (bcell, CRED_CELL));
if (sd->handled_dc)
return;
new_amount = gnc_split_register_debcred_cell_value (reg); new_amount = gnc_split_register_debcred_cell_value (reg);
/* How to interpret new_amount depends on our view of this /* How to interpret new_amount depends on our view of this
@ -406,12 +396,9 @@ gnc_split_register_save_debcred_cell (BasicCell * bcell,
*/ */
/* First, compute the conversion rate to convert the value to the /* First, compute the conversion rate to convert the value to the
* amount. Use the RATE_CELL (if it exists) -- if not, then assume * amount.
* it is 1.
*/ */
convrate = gnc_split_register_get_rate_cell (reg, RATE_CELL); convrate = gnc_split_register_get_rate_cell (reg, RATE_CELL);
if (gnc_numeric_zero_p (convrate))
convrate = gnc_numeric_create (100,100);
/* Now compute/set the split value. Amount is in the register /* Now compute/set the split value. Amount is in the register
* currency but we need to convert to the txn currency. * currency but we need to convert to the txn currency.
@ -456,6 +443,23 @@ gnc_split_register_save_debcred_cell (BasicCell * bcell,
GNC_RND_ROUND); GNC_RND_ROUND);
xaccSplitSetAmount (sd->split, new_amount); xaccSplitSetAmount (sd->split, new_amount);
} }
}
static void
gnc_split_register_save_debcred_cell (BasicCell * bcell,
gpointer save_data,
gpointer user_data)
{
SRSaveData *sd = save_data;
SplitRegister *reg = user_data;
g_return_if_fail (gnc_basic_cell_has_name (bcell, DEBT_CELL) ||
gnc_basic_cell_has_name (bcell, CRED_CELL));
if (sd->handled_dc)
return;
gnc_split_register_save_amount_values (sd, reg);
sd->handled_dc = TRUE; sd->handled_dc = TRUE;
sd->do_scrub = TRUE; sd->do_scrub = TRUE;
@ -554,12 +558,15 @@ gnc_split_register_save_cells (gpointer save_data,
*/ */
if (!sd->handled_dc) if (!sd->handled_dc)
{ {
gnc_split_register_save_amount_values (sd, reg);
#if 0
gnc_numeric value, amount; gnc_numeric value, amount;
amount = xaccSplitGetAmount (sd->split); amount = xaccSplitGetAmount (sd->split);
value = gnc_numeric_div (amount, rate, gnc_commodity_get_fraction (txn_cur), value = gnc_numeric_div (amount, rate, gnc_commodity_get_fraction (txn_cur),
GNC_RND_ROUND); GNC_RND_ROUND);
xaccSplitSetValue (sd->split, value); xaccSplitSetValue (sd->split, value);
#endif
} }
} }
} }