IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Remove SIGFIG rounding from price calculation.

Browse Source 
Prices shouldn't be rounded except for display.
This commit is contained in:
John Ralls 2017-12-18 09:46:42 -08:00
parent 318f7ebc4f
commit 7061803596
2 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libgnucash/engine/Split.c
View File

@ -60,8 +60,6 @@
const char *void_former_amt_str = "void-former-amount"; const char *void_former_amt_str = "void-former-amount";
const char *void_former_val_str = "void-former-value"; const char *void_former_val_str = "void-former-value";
#define PRICE_SIGFIGS 6
/* This static indicates the debugging module that this .o belongs to. */ /* This static indicates the debugging module that this .o belongs to. */
static QofLogModule log_module = GNC_MOD_ENGINE; static QofLogModule log_module = GNC_MOD_ENGINE;
@ -1956,7 +1954,6 @@ xaccSplitGetSharePrice (const Split * split)
} }
price = gnc_numeric_div(val, amt, price = gnc_numeric_div(val, amt,
GNC_DENOM_AUTO, GNC_DENOM_AUTO,
GNC_HOW_DENOM_SIGFIGS(PRICE_SIGFIGS) |
GNC_HOW_RND_ROUND_HALF_UP); GNC_HOW_RND_ROUND_HALF_UP);
/* During random checks we can get some very weird prices. Let's /* During random checks we can get some very weird prices. Let's

5
libgnucash/engine/test/utest-Split.cpp
View File

@ -1670,7 +1670,6 @@ test_xaccSplitGetSharePrice (Fixture *fixture, gconstpointer pData)
gnc_numeric expected = gnc_numeric_create (1, 1); gnc_numeric expected = gnc_numeric_create (1, 1);
Split *split = fixture->split; Split *split = fixture->split;
/* Warning: this is a define in Split.c */ /* Warning: this is a define in Split.c */
const guint PRICE_SIGFIGS = 6;
char *logdomain = "gnc.engine"; char *logdomain = "gnc.engine";
GLogLevelFlags loglevel = static_cast<GLogLevelFlags>(G_LOG_LEVEL_CRITICAL | G_LOG_FLAG_FATAL); GLogLevelFlags loglevel = static_cast<GLogLevelFlags>(G_LOG_LEVEL_CRITICAL | G_LOG_FLAG_FATAL);
TestErrorStruct check = { loglevel, logdomain, NULL, 0 }; TestErrorStruct check = { loglevel, logdomain, NULL, 0 };
@ -1685,7 +1684,6 @@ test_xaccSplitGetSharePrice (Fixture *fixture, gconstpointer pData)
expected = gnc_numeric_div (split->value, split->amount, expected = gnc_numeric_div (split->value, split->amount,
GNC_DENOM_AUTO, GNC_DENOM_AUTO,
GNC_HOW_DENOM_SIGFIGS (PRICE_SIGFIGS) |
GNC_HOW_RND_ROUND_HALF_UP); GNC_HOW_RND_ROUND_HALF_UP);
result = xaccSplitGetSharePrice (split); result = xaccSplitGetSharePrice (split);
@ -1710,7 +1708,6 @@ test_xaccSplitGetSharePrice (Fixture *fixture, gconstpointer pData)
split->value = gnc_numeric_create (3, 789304166); split->value = gnc_numeric_create (3, 789304166);
quotient = gnc_numeric_div (split->value, split->amount, quotient = gnc_numeric_div (split->value, split->amount,
GNC_DENOM_AUTO, GNC_DENOM_AUTO,
GNC_HOW_DENOM_SIGFIGS (PRICE_SIGFIGS) |
GNC_HOW_RND_ROUND_HALF_UP); GNC_HOW_RND_ROUND_HALF_UP);
check.msg = g_strdup_printf ("[xaccSplitGetSharePrice()] " check.msg = g_strdup_printf ("[xaccSplitGetSharePrice()] "
"Computing share price failed (%d): [ %" "Computing share price failed (%d): [ %"
@ -1730,7 +1727,6 @@ test_xaccSplitGetSharePrice (Fixture *fixture, gconstpointer pData)
split->value = gnc_numeric_create (3, 0); split->value = gnc_numeric_create (3, 0);
quotient = gnc_numeric_div (split->value, split->amount, quotient = gnc_numeric_div (split->value, split->amount,
GNC_DENOM_AUTO, GNC_DENOM_AUTO,
GNC_HOW_DENOM_SIGFIGS (PRICE_SIGFIGS) |
GNC_HOW_RND_ROUND_HALF_UP); GNC_HOW_RND_ROUND_HALF_UP);
check.msg = g_strdup_printf ("[xaccSplitGetSharePrice()] " check.msg = g_strdup_printf ("[xaccSplitGetSharePrice()] "
"Computing share price failed (%d): [ %" "Computing share price failed (%d): [ %"
@ -1750,7 +1746,6 @@ test_xaccSplitGetSharePrice (Fixture *fixture, gconstpointer pData)
split->value = gnc_numeric_create (3, 789304166); split->value = gnc_numeric_create (3, 789304166);
quotient = gnc_numeric_div (split->value, split->amount, quotient = gnc_numeric_div (split->value, split->amount,
GNC_DENOM_AUTO, GNC_DENOM_AUTO,
GNC_HOW_DENOM_SIGFIGS (PRICE_SIGFIGS) |
GNC_HOW_RND_ROUND_HALF_UP); GNC_HOW_RND_ROUND_HALF_UP);
check.msg = g_strdup_printf ("[xaccSplitGetSharePrice()] " check.msg = g_strdup_printf ("[xaccSplitGetSharePrice()] "
"Computing share price failed (%d): [ %" "Computing share price failed (%d): [ %"