IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Disallow using "Jump" on an expanded split for the current account

Browse Source 
If you've selected a split for this account, for consistency with selecting
the split of another account we should do nothing. You're already on the
account for the split you selected.

Previously it would still go to the "other" account but that's going to
make the "multiple split" options confusing.
This commit is contained in:
Simon Arlott 2023-06-05 20:11:34 +01:00
parent 618cd55826
commit 79c6c3732f
No known key found for this signature in database
GPG Key ID: DF001BFD83E75990
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
gnucash/gnome/gnc-plugin-page-register.cpp
View File

@ -4899,6 +4899,28 @@ gnc_plugin_page_register_cmd_jump (GSimpleAction *simple,
leader = gnc_ledger_display_leader (priv->ledger); leader = gnc_ledger_display_leader (priv->ledger);
if (account == leader) if (account == leader)
{ {
CursorClass cursor_class = gnc_split_register_get_current_cursor_class (reg);
if (cursor_class == CURSOR_CLASS_SPLIT)
{
/* If you've selected the transaction itself, we jump to the "other"
* account corresponding to the anchoring split.
*
* If you've selected the split for another account, we jump to that
* split's account (account != leader, so this block is never
* reached).
*
* If you've selected a split for this account, for consistency with
* selecting the split of another account we should do nothing.
* You're already on the account for the split you selected.
*
* We could jump to a different anchoring split but that'll be very
* subtle and only cause problems because it'll have to save any
* modifications to the current register.
*/
LEAVE ("split for this account");
return;
}
split = xaccSplitGetOtherSplit (split); split = xaccSplitGetOtherSplit (split);
if (split == NULL) if (split == NULL)
{ {