IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

[gnc-dense-cal] further GList* and char* leaks

Browse Source 
- mark->name and mark->info both leaked
- fixing poorly written for loop to g_list_free tags properly
This commit is contained in:
Christopher Lam 2022-07-30 16:21:03 +08:00
parent accdf9e852
commit 7bc7737476
1 changed files with 13 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
gnucash/gnome-utils/gnc-dense-cal.c
View File

@ -821,6 +821,7 @@ gdc_free_all_mark_data(GncDenseCal *dcal)
gdc_mark_data *mark = l->data; gdc_mark_data *mark = l->data;
g_list_free (mark->ourMarks); g_list_free (mark->ourMarks);
g_free (mark->name); g_free (mark->name);
g_free (mark->info);
g_free (mark); g_free (mark);
} }
g_list_free(dcal->markData); g_list_free(dcal->markData);
@ -1888,26 +1889,22 @@ cleanup:
static void static void
gdc_add_markings(GncDenseCal *cal) gdc_add_markings(GncDenseCal *cal)
{ {
GList *tags; GList *tags = gnc_dense_cal_model_get_contained(cal->model);
tags = gnc_dense_cal_model_get_contained(cal->model);
for (; tags != NULL; tags = tags->next) for (GList *n = tags; n; n = n->next)
{ gdc_add_tag_markings(cal, GPOINTER_TO_UINT(n->data));
guint tag = GPOINTER_TO_UINT(tags->data);
gdc_add_tag_markings(cal, tag);
}
g_list_free(tags); g_list_free(tags);
} }
static void static void
gdc_remove_markings(GncDenseCal *cal) gdc_remove_markings(GncDenseCal *cal)
{ {
GList *tags; GList *tags = gnc_dense_cal_model_get_contained(cal->model);
tags = gnc_dense_cal_model_get_contained(cal->model);
for (; tags != NULL; tags = tags->next) for (GList *n = tags; n; n = n->next)
{ gdc_mark_remove(cal, GPOINTER_TO_UINT(n->data), FALSE);
guint tag = GPOINTER_TO_UINT(tags->data);
gdc_mark_remove(cal, tag, FALSE);
}
g_list_free(tags); g_list_free(tags);
} }
@ -2051,6 +2048,8 @@ gdc_mark_remove(GncDenseCal *dcal, guint mark_to_remove, gboolean redraw)
} }
g_list_free(mark_data->ourMarks); g_list_free(mark_data->ourMarks);
dcal->markData = g_list_remove(dcal->markData, mark_data); dcal->markData = g_list_remove(dcal->markData, mark_data);
g_free (mark_data->name);
g_free (mark_data->info);
g_free(mark_data); g_free(mark_data);
if (redraw) if (redraw)