IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix CoreApp() constructor misuse

Browse Source 
- spotted by [bugprone-undelegated-constructor] [bugprone-unused-raii]

gnucash/gnucash-core-app.cpp:218:5: warning: did you intend to call a delegated constructor? A temporary object is created here instead [bugprone-undelegated-constructor]
    CoreApp();
    ^
gnucash/gnucash-core-app.cpp:218:5: warning: object destroyed immediately after creation; did you mean to name the object? [bugprone-unused-raii]
    CoreApp();
    ^      ~~
            give_me_a_name
This commit is contained in:
Richard Cohen 2023-03-01 18:22:10 +00:00
parent 7d5154ce18
commit 7ec99e116a
2 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
gnucash/gnucash-core-app.cpp
View File

@ -167,7 +167,7 @@ gnc_log_init (const std::vector <std::string> log_flags,
} }
} }
Gnucash::CoreApp::CoreApp () Gnucash::CoreApp::CoreApp (const char* app_name) : m_app_name {app_name}
{ {
#ifdef ENABLE_BINRELOC #ifdef ENABLE_BINRELOC
{ {
@ -210,14 +210,6 @@ Gnucash::CoreApp::CoreApp ()
std::cerr.imbue (gnc_get_boost_locale()); std::cerr.imbue (gnc_get_boost_locale());
std::cout.imbue (gnc_get_boost_locale()); std::cout.imbue (gnc_get_boost_locale());
g_free(localedir); g_free(localedir);
}
Gnucash::CoreApp::CoreApp (const char* app_name)
{
CoreApp();
m_app_name = std::string(app_name);
// Now that gettext is properly initialized, set our help tagline. // Now that gettext is properly initialized, set our help tagline.
m_tagline = _("- GnuCash, accounting for personal and small business finance"); m_tagline = _("- GnuCash, accounting for personal and small business finance");

1
gnucash/gnucash-core-app.hpp
View File

@ -39,7 +39,6 @@ namespace bpo = boost::program_options;
class CoreApp class CoreApp
{ {
public: public:
CoreApp ();
CoreApp (const char* app_name); CoreApp (const char* app_name);
void parse_command_line (int argc, char **argv); void parse_command_line (int argc, char **argv);