IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Bug 742352 - Budget Summary section does not show expense totals

Browse Source 
Fixed buget add up issue.
https://bugzilla.gnome.org/show_bug.cgi?id=742352
This commit is contained in:
Matt G 2015-12-21 13:03:44 +11:00 committed by Geert Janssens
parent c56a4d9593
commit 7ef2568939
1 changed files with 98 additions and 63 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

159
src/gnome/gnc-budget-view.c
View File

@ -154,6 +154,7 @@ struct GncBudgetViewPrivate
Account* expenses; Account* expenses;
Account* assets; Account* assets;
Account* liabilities; Account* liabilities;
Account* rootAcct;
}; };
#define GNC_BUDGET_VIEW_GET_PRIVATE(o) \ #define GNC_BUDGET_VIEW_GET_PRIVATE(o) \
@ -216,10 +217,12 @@ gnc_budget_view_init(GncBudgetView *budget_view)
ENTER("view %p", budget_view); ENTER("view %p", budget_view);
priv = GNC_BUDGET_VIEW_GET_PRIVATE(budget_view); priv = GNC_BUDGET_VIEW_GET_PRIVATE(budget_view);
/* Keep track of the top level asset, liability, income and expense accounts */ /* Keep track of the root and top level asset, liability, income and expense accounts */
root = gnc_book_get_root_account(gnc_get_current_book()); root = gnc_book_get_root_account(gnc_get_current_book());
num_top_accounts = gnc_account_n_children(root); num_top_accounts = gnc_account_n_children(root);
priv->rootAcct = root;
for (i = 0; i < num_top_accounts; ++i) for (i = 0; i < num_top_accounts; ++i)
{ {
Account* acc = gnc_account_nth_child(root, i); Account* acc = gnc_account_nth_child(root, i);
@ -716,9 +719,9 @@ budget_accum_helper(Account* account, gpointer data)
} }
} }
/** \brief Function to calculate the accumulated budget amount in a given account for a specified period. /** \brief Function to calculate the accumulated budget amount in a given account at a specified period number.
This function uses the \ref budget_accum_helper to calculate the accumulated budget amount in a given budget account for a specified period. Specifically, it uses the function \ref gnc_account_foreach_child function passing through an instance of \ref budget_accum_helper. This function uses the \ref budget_accum_helper to calculate the accumulated budget amount in a given budget account for a specified period number. If the acocunt does not have children, then it simply returns the balance of the account.
*/ */
static gnc_numeric static gnc_numeric
gbv_get_accumulated_budget_amount(GncBudget* budget, Account* account, guint period_num) gbv_get_accumulated_budget_amount(GncBudget* budget, Account* account, guint period_num)
@ -728,9 +731,19 @@ gbv_get_accumulated_budget_amount(GncBudget* budget, Account* account, guint per
info.total = gnc_numeric_zero(); info.total = gnc_numeric_zero();
info.budget = budget; info.budget = budget;
info.period_num = period_num; info.period_num = period_num;
gnc_account_foreach_child(account, budget_accum_helper, &info);
return info.total;
if (!gnc_budget_is_account_period_value_set(budget, account, period_num))
{
gnc_account_foreach_child(account, budget_accum_helper, &info);
}
else
{
info.total = gnc_budget_get_account_period_value(budget, account, period_num);
}
return info.total;
} }
/** \brief Calculates and displays budget amount for a period in a defined account. /** \brief Calculates and displays budget amount for a period in a defined account.
@ -866,7 +879,10 @@ budget_col_edited(Account *account, GtkTreeViewColumn *col,
/** \brief Function to find the total in a column of budget provided and display the info in the totals tree widget. /** \brief Function to find the total in a column of budget provided and display the info in the totals tree widget.
This function looks at which type of account is in question, and then calls the function \ref gbv_get_accumulated_budget_amount on the root account (assuming that we are not at a totals column) or \ref bgv_get_total_for_account if we are. It then displays this information in the totals tree widget. This function is called on each row within the totals tree (i.e. assets, expenses, transfers, and totals) in order to
update the total values in the totals tree (grand totals at the bottom of the budget page). It looks at which type of account is currently being examined, and then calls the function
\ref gbv_get_accumulated_budget_amount on all of the relevant children accounts of the root. It then sets the value and color of the cell based on this information in the totals tree widget.
*/ */
static void static void
totals_col_source(GtkTreeViewColumn *col, GtkCellRenderer *cell, totals_col_source(GtkTreeViewColumn *col, GtkCellRenderer *cell,
@ -877,10 +893,14 @@ totals_col_source(GtkTreeViewColumn *col, GtkCellRenderer *cell,
GncBudgetViewPrivate* priv; GncBudgetViewPrivate* priv;
gint row_type; gint row_type;
GncBudget *budget; GncBudget *budget;
Account* account; // used to make things easier in the adding up processes
gint period_num; gint period_num;
gnc_numeric value; gnc_numeric value; // used to assist in adding and subtracting
gchar amtbuff[100]; //FIXME: overkill, where's the #define? gchar amtbuff[100]; //FIXME: overkill, where's the #define?
gint width;
gint width; // FIXME: VARIABLE NOT NEEDED?
gint i;
view = GNC_BUDGET_VIEW(user_data); view = GNC_BUDGET_VIEW(user_data);
priv = GNC_BUDGET_VIEW_GET_PRIVATE(view); priv = GNC_BUDGET_VIEW_GET_PRIVATE(view);
@ -890,78 +910,92 @@ totals_col_source(GtkTreeViewColumn *col, GtkCellRenderer *cell,
period_num = GPOINTER_TO_INT(g_object_get_data(G_OBJECT(col), period_num = GPOINTER_TO_INT(g_object_get_data(G_OBJECT(col),
"period_num")); "period_num"));
gnc_numeric totalincome;
totalincome = gnc_numeric_zero();
gnc_numeric totalexpenses;
totalexpenses = gnc_numeric_zero();
gnc_numeric totalassets;
totalassets = gnc_numeric_zero();
gnc_numeric totalliabilities;
totalliabilities = gnc_numeric_zero();
gint num_top_accounts = gnc_account_n_children(priv->rootAcct);
// step through each child account of the root, find the total income, expenses, liabilities, and assets.
for (i = 0; i < num_top_accounts; ++i)
{
account = gnc_account_nth_child(priv->rootAcct, i);
// find the total for this account
if (period_num < 0)
{
value = bgv_get_total_for_account(account, budget);
}
else
{
value = gbv_get_accumulated_budget_amount(budget, account, period_num);
}
// test for what account type, and add 'value' to the appopriate total
if (xaccAccountGetType(account) == ACCT_TYPE_INCOME)
{
totalincome = gnc_numeric_add(totalincome, value, GNC_DENOM_AUTO, GNC_HOW_DENOM_LCD);
}
else if (xaccAccountGetType(account) == ACCT_TYPE_EXPENSE)
{
totalexpenses = gnc_numeric_add(totalexpenses, value, GNC_DENOM_AUTO, GNC_HOW_DENOM_LCD);
}
else if (xaccAccountGetType(account) == ACCT_TYPE_ASSET)
{
totalassets = gnc_numeric_add(totalassets, value, GNC_DENOM_AUTO, GNC_HOW_DENOM_LCD);
}
else if (xaccAccountGetType(account) == ACCT_TYPE_LIABILITY)
{
totalliabilities = gnc_numeric_add(totalliabilities, value, GNC_DENOM_AUTO, GNC_HOW_DENOM_LCD);
}
else
{
// Do nothing because this account is not of interest
}
}
// at this point we should have variables holding the values for assets, liabilities, expenses and incomes.
// Set the text to display, depending on which of the totals rows we are currently looking at
if (row_type == TOTALS_TYPE_INCOME) if (row_type == TOTALS_TYPE_INCOME)
{ {
if (period_num >= 0) // FIXME: There must be a better way to get the GncAccountPrintInfo object than this. Would prefer to depreciate the tracking of top level accounts.
{ xaccSPrintAmount(amtbuff, totalincome,
value = gbv_get_accumulated_budget_amount(budget, priv->income, period_num);
}
else
{
value = bgv_get_total_for_account(priv->income, budget);
}
xaccSPrintAmount(amtbuff, value,
gnc_account_print_info(priv->income, FALSE)); gnc_account_print_info(priv->income, FALSE));
g_object_set(cell, "foreground", "black", NULL); g_object_set(cell, "foreground", "black", NULL);
} }
else if (row_type == TOTALS_TYPE_EXPENSES) else if (row_type == TOTALS_TYPE_EXPENSES)
{ {
if (period_num >= 0)
{ xaccSPrintAmount(amtbuff, totalexpenses,
value = gbv_get_accumulated_budget_amount(budget, priv->expenses, period_num);
}
else
{
value = bgv_get_total_for_account(priv->expenses, budget);
}
xaccSPrintAmount(amtbuff, value,
gnc_account_print_info(priv->expenses, FALSE)); gnc_account_print_info(priv->expenses, FALSE));
g_object_set(cell, "foreground", "black", NULL); g_object_set(cell, "foreground", "black", NULL);
} }
else if (row_type == TOTALS_TYPE_TRANSFERS) else if (row_type == TOTALS_TYPE_TRANSFERS)
{ {
gnc_numeric assets;
gnc_numeric liabilities;
if (period_num >= 0) xaccSPrintAmount(amtbuff, gnc_numeric_sub(totalassets, totalliabilities, GNC_DENOM_AUTO, GNC_HOW_DENOM_LCD),
{
assets = gbv_get_accumulated_budget_amount(budget, priv->assets, period_num);
liabilities = gbv_get_accumulated_budget_amount(budget, priv->liabilities, period_num);
}
else
{
assets = bgv_get_total_for_account(priv->assets, budget);
liabilities = bgv_get_total_for_account(priv->liabilities, budget);
}
value = gnc_numeric_sub(assets, liabilities, GNC_DENOM_AUTO, GNC_HOW_DENOM_LCD);
xaccSPrintAmount(amtbuff, value,
gnc_account_print_info(priv->assets, FALSE)); gnc_account_print_info(priv->assets, FALSE));
g_object_set(cell, "foreground", "black", NULL); g_object_set(cell, "foreground", "black", NULL);
} }
else if (row_type == TOTALS_TYPE_TOTAL) else if (row_type == TOTALS_TYPE_TOTAL)
{ {
gnc_numeric income; value = gnc_numeric_sub(totalincome, totalexpenses, GNC_DENOM_AUTO, GNC_HOW_DENOM_LCD);
gnc_numeric expenses; value = gnc_numeric_sub(value, totalassets, GNC_DENOM_AUTO, GNC_HOW_DENOM_LCD);
gnc_numeric assets; value = gnc_numeric_add(value, totalliabilities, GNC_DENOM_AUTO, GNC_HOW_DENOM_LCD);
gnc_numeric liabilities;
if (period_num >= 0)
{
income = gbv_get_accumulated_budget_amount(budget, priv->income, period_num);
expenses = gbv_get_accumulated_budget_amount(budget, priv->expenses, period_num);
assets = gbv_get_accumulated_budget_amount(budget, priv->assets, period_num);
liabilities = gbv_get_accumulated_budget_amount(budget, priv->liabilities, period_num);
}
else
{
income = bgv_get_total_for_account(priv->income, budget);
expenses = bgv_get_total_for_account(priv->expenses, budget);
assets = bgv_get_total_for_account(priv->assets, budget);
liabilities = bgv_get_total_for_account(priv->liabilities, budget);
}
value = gnc_numeric_sub(income, expenses, GNC_DENOM_AUTO, GNC_HOW_DENOM_LCD);
value = gnc_numeric_sub(value, assets, GNC_DENOM_AUTO, GNC_HOW_DENOM_LCD);
value = gnc_numeric_add(value, liabilities, GNC_DENOM_AUTO, GNC_HOW_DENOM_LCD);
xaccSPrintAmount(amtbuff, value, xaccSPrintAmount(amtbuff, value,
gnc_account_print_info(priv->assets, FALSE)); gnc_account_print_info(priv->assets, FALSE));
if (gnc_numeric_negative_p(value)) if (gnc_numeric_negative_p(value))
@ -975,6 +1009,7 @@ totals_col_source(GtkTreeViewColumn *col, GtkCellRenderer *cell,
} }
else else
{ {
// if it reaches here then the row type was not set correctly
g_strlcpy(amtbuff, "error", sizeof(amtbuff)); g_strlcpy(amtbuff, "error", sizeof(amtbuff));
} }