IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

[gnc-plugin-page-register] g_slist_free param_list

Browse Source 
If (reg->type == SEARCH_LEDGER) then the GSList* created by
qof_query_build_param_list would not be freed. This reordering avoids
allocating GSList altogether when not needed.
This commit is contained in:
Christopher Lam 2022-07-30 23:16:24 +08:00
parent 6c70f2c22d
commit 815eeb496f
1 changed files with 5 additions and 6 deletions

11
gnucash/gnome/gnc-plugin-page-register.c
View File

@ -2738,7 +2738,6 @@ static void
gnc_ppr_update_status_query (GncPluginPageRegister* page)
{
GncPluginPageRegisterPrivate* priv;
GSList* param_list;
Query* query;
SplitRegister* reg;
@ -2762,9 +2761,9 @@ gnc_ppr_update_status_query (GncPluginPageRegister* page)
reg = gnc_ledger_display_get_split_register (priv->ledger);
/* Remove the old status match */
param_list = qof_query_build_param_list (SPLIT_RECONCILE, NULL);
if (param_list && (reg->type != SEARCH_LEDGER))
if (reg->type != SEARCH_LEDGER)
{
GSList *param_list = qof_query_build_param_list (SPLIT_RECONCILE, NULL);
qof_query_purge_terms (query, param_list);
g_slist_free (param_list);
}
@ -2802,7 +2801,6 @@ static void
gnc_ppr_update_date_query (GncPluginPageRegister* page)
{
GncPluginPageRegisterPrivate* priv;
GSList* param_list;
Query* query;
SplitRegister* reg;
@ -2827,9 +2825,10 @@ gnc_ppr_update_date_query (GncPluginPageRegister* page)
reg = gnc_ledger_display_get_split_register (priv->ledger);
/* Delete any existing old date spec. */
param_list = qof_query_build_param_list (SPLIT_TRANS, TRANS_DATE_POSTED, NULL);
if (param_list && (reg->type != SEARCH_LEDGER))
if (reg->type != SEARCH_LEDGER)
{
GSList *param_list = qof_query_build_param_list (SPLIT_TRANS,
TRANS_DATE_POSTED, NULL);
qof_query_purge_terms (query, param_list);
g_slist_free (param_list);
}