diff --git a/gnucash/report/business-reports/easy-invoice.scm b/gnucash/report/business-reports/easy-invoice.scm
index de14f36c72..4b89071856 100644
--- a/gnucash/report/business-reports/easy-invoice.scm
+++ b/gnucash/report/business-reports/easy-invoice.scm
@@ -776,12 +776,11 @@
(add-html! document "")
)
- ; add the date
- (let ((date-table #f)
- (post-date (gncInvoiceGetDatePosted invoice))
- (due-date (gncInvoiceGetDateDue invoice)))
- (if (not (zero? post-date))
- (begin
+ ;; add the date
+ (if (gncInvoiceIsPosted invoice)
+ (let ((date-table #f)
+ (post-date (gncInvoiceGetDatePosted invoice))
+ (due-date (gncInvoiceGetDateDue invoice)))
(set! date-table (make-date-table))
(make-date-row! date-table (_ "Date") post-date date-format)
(if (opt-val "Display" "Due Date")
@@ -790,7 +789,7 @@
(add-html! document
(string-append ""
(_ "INVOICE NOT POSTED")
- ""))))
+ "")))
(make-break! document)
diff --git a/gnucash/report/business-reports/fancy-invoice.scm b/gnucash/report/business-reports/fancy-invoice.scm
index 4003f8be9b..17a47a7544 100644
--- a/gnucash/report/business-reports/fancy-invoice.scm
+++ b/gnucash/report/business-reports/fancy-invoice.scm
@@ -857,19 +857,17 @@
'attribute (list "cellpadding" 0)
'attribute (list "width" "100%"))
- (set! date-object (let ((date-table #f)
- (post-date (gncInvoiceGetDatePosted invoice))
- (due-date (gncInvoiceGetDateDue invoice)))
-
- (if (not (zero? post-date))
- (begin
+ (set! date-object
+ (if (gncInvoiceIsPosted invoice)
+ (let ((date-table #f)
+ (post-date (gncInvoiceGetDatePosted invoice))
+ (due-date (gncInvoiceGetDateDue invoice)))
(set! date-table (make-date-table))
- ;; oli-custom - moved invoice number here
(gnc:html-table-append-row!
;; Translators: %s below is "Invoice" or "Bill" or even the
;; custom title from the options. The next column contains
;; the number of the document.
- date-table (list (sprintf #f (_ "%s #") title) (gncInvoiceGetID invoice)))
+ date-table (list (sprintf #f (_ "%s #") title) (gncInvoiceGetID invoice)))
;; Translators: The first %s below is "Invoice" or
;; "Bill" or even the custom title from the
;; options. This string sucks for i18n, but I don't
@@ -879,10 +877,8 @@
(make-date-row! date-table (_ "Due Date") due-date date-format)
date-table)
(gnc:make-html-text
- ;; oli-custom - FIXME: I have a feeling I broke a
- ;; translation by not using string-expand for
- (string-append title "
"
- (_ "Invoice in progress..."))))))
+ (string-append title "
"
+ (_ "Invoice in progress...")))))
(gnc:html-table-append-row!
helper-table
diff --git a/gnucash/report/business-reports/invoice.scm b/gnucash/report/business-reports/invoice.scm
index a54f02e850..a74e48f1b7 100644
--- a/gnucash/report/business-reports/invoice.scm
+++ b/gnucash/report/business-reports/invoice.scm
@@ -708,22 +708,18 @@
document
(make-myname-table book date-format))
- (let ((date-table #f)
- (post-date (gncInvoiceGetDatePosted invoice))
- (due-date (gncInvoiceGetDateDue invoice)))
-
- (if (not (zero? post-date))
- (begin
- (set! date-table (make-date-table))
- (make-date-row! date-table (string-append title " " (_ "Date")) post-date date-format)
- (make-date-row! date-table (_ "Due Date") due-date date-format)
- (gnc:html-document-add-object! document date-table))
- (gnc:html-document-add-object!
- document
- (gnc:make-html-text
- (_ "Invoice in progress...")))))
-
-
+ (if (gncInvoiceIsPosted invoice)
+ (let ((date-table #f)
+ (post-date (gncInvoiceGetDatePosted invoice))
+ (due-date (gncInvoiceGetDateDue invoice)))
+ (set! date-table (make-date-table))
+ (make-date-row! date-table (string-append title " " (_ "Date")) post-date date-format)
+ (make-date-row! date-table (_ "Due Date") due-date date-format)
+ (gnc:html-document-add-object! document date-table))
+ (gnc:html-document-add-object!
+ document
+ (gnc:make-html-text
+ (_ "Invoice in progress..."))))
(make-break! document)
(make-break! document)
diff --git a/gnucash/report/business-reports/job-report.scm b/gnucash/report/business-reports/job-report.scm
index 327e46bc57..e1250fc972 100644
--- a/gnucash/report/business-reports/job-report.scm
+++ b/gnucash/report/business-reports/job-report.scm
@@ -193,7 +193,7 @@
(if (date-due-col column-vector)
(addto! row-contents
(if (and due-date
- (not (zero? due-date)))
+ (gncInvoiceDateExists due-date))
(qof-print-date due-date)
"")))
(if (num-col column-vector)
diff --git a/gnucash/report/business-reports/owner-report.scm b/gnucash/report/business-reports/owner-report.scm
index 3f06c12b04..4c7dd3561b 100644
--- a/gnucash/report/business-reports/owner-report.scm
+++ b/gnucash/report/business-reports/owner-report.scm
@@ -291,7 +291,7 @@
(if (date-due-col column-vector)
(addto! row-contents
(if (and due-date
- (not (zero? due-date)))
+ (gncInvoiceDateExists due-date))
(qof-print-date due-date)
"")))
(if (num-col column-vector)
diff --git a/gnucash/report/business-reports/taxinvoice.eguile.scm b/gnucash/report/business-reports/taxinvoice.eguile.scm
index 159fec7e94..8e359b5c46 100644
--- a/gnucash/report/business-reports/taxinvoice.eguile.scm
+++ b/gnucash/report/business-reports/taxinvoice.eguile.scm
@@ -246,7 +246,7 @@