IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Pass argc and argv by value instead of by reference

Browse Source 
Contrary to gtk_init, boost::program_options won't remove parsed options from
the argument list so there's no need to provide the option to update
the list.
This commit is contained in:
Geert Janssens 2020-05-29 11:01:01 +02:00
parent a435b4c4f6
commit 88ed957d2a
4 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gnucash/gnucash-cli.cpp
View File

@ -114,7 +114,7 @@ namespace Gnucash {
{ {
public: public:
GnucashCli (const char* app_name); GnucashCli (const char* app_name);
void parse_command_line (int *argc, char ***argv); void parse_command_line (int argc, char **argv);
void start (int argc, char **argv); void start (int argc, char **argv);
private: private:
void configure_program_options (void); void configure_program_options (void);
@ -130,7 +130,7 @@ Gnucash::GnucashCli::GnucashCli (const char *app_name) : Gnucash::CoreApp (app_n
} }
void void
Gnucash::GnucashCli::parse_command_line (int *argc, char ***argv) Gnucash::GnucashCli::parse_command_line (int argc, char **argv)
{ {
Gnucash::CoreApp::parse_command_line (argc, argv); Gnucash::CoreApp::parse_command_line (argc, argv);
@ -171,7 +171,7 @@ main(int argc, char **argv)
{ {
Gnucash::GnucashCli application (argv[0]); Gnucash::GnucashCli application (argv[0]);
application.parse_command_line (&argc, &argv); application.parse_command_line (argc, argv);
application.start (argc, argv); application.start (argc, argv);
exit(0); /* never reached */ exit(0); /* never reached */

4
gnucash/gnucash-core-app.cpp
View File

@ -565,7 +565,7 @@ Gnucash::CoreApp::CoreApp (const char* app_name)
* before parsing any arguments if the GUI can't be initialized. * before parsing any arguments if the GUI can't be initialized.
*/ */
void void
Gnucash::CoreApp::parse_command_line (int *argc, char ***argv) Gnucash::CoreApp::parse_command_line (int argc, char **argv)
{ {
#ifdef __MINGW64__ #ifdef __MINGW64__
wchar_t *tmp_log_to_filename = NULL; wchar_t *tmp_log_to_filename = NULL;
@ -573,7 +573,7 @@ Gnucash::CoreApp::parse_command_line (int *argc, char ***argv)
char *tmp_log_to_filename = NULL; char *tmp_log_to_filename = NULL;
#endif #endif
bpo::store (bpo::command_line_parser (*argc, *argv). bpo::store (bpo::command_line_parser (argc, argv).
options (*m_opt_desc.get()).positional(m_pos_opt_desc).run(), m_opt_map); options (*m_opt_desc.get()).positional(m_pos_opt_desc).run(), m_opt_map);
bpo::notify (m_opt_map); bpo::notify (m_opt_map);

2
gnucash/gnucash-core-app.hpp
View File

@ -38,7 +38,7 @@ public:
CoreApp (); CoreApp ();
CoreApp (const char* app_name); CoreApp (const char* app_name);
void parse_command_line (int *argc, char ***argv); void parse_command_line (int argc, char **argv);
void start (void); void start (void);
const char *get_file_to_load (void); const char *get_file_to_load (void);

6
gnucash/gnucash.cpp
View File

@ -357,7 +357,7 @@ namespace Gnucash {
{ {
public: public:
Gnucash (const char* app_name); Gnucash (const char* app_name);
void parse_command_line (int *argc, char ***argv); void parse_command_line (int argc, char **argv);
std::string get_quotes_file (void) std::string get_quotes_file (void)
{ return m_quotes_file; } { return m_quotes_file; }
@ -377,7 +377,7 @@ Gnucash::Gnucash::Gnucash (const char *app_name) : Gnucash::CoreApp (app_name)
void void
Gnucash::Gnucash::parse_command_line (int *argc, char ***argv) Gnucash::Gnucash::parse_command_line (int argc, char **argv)
{ {
Gnucash::CoreApp::parse_command_line (argc, argv); Gnucash::CoreApp::parse_command_line (argc, argv);
@ -445,7 +445,7 @@ main(int argc, char ** argv)
return 1; return 1;
} }
application.parse_command_line (&argc, &argv); application.parse_command_line (argc, argv);
application.start(); application.start();
/* If asked via a command line parameter, fetch quotes only */ /* If asked via a command line parameter, fetch quotes only */