IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-20 11:48:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Csv Trans Imp - remove redundant test

Browse Source 
Remainder of the code ensures a GncPreSplit account is always
set to either the base account value or a value of an account
column. It's useless to try once more to set a base account
right before creating the preliminary transactions.
This commit is contained in:
Geert Janssens 2023-02-11 11:33:22 +01:00
parent 3af9374126
commit 88fd034f89
1 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
gnucash/import-export/csv-imp/gnc-import-tx.cpp
View File

@ -636,18 +636,13 @@ void GncTxImport::create_transaction (std::vector<parse_line_t>::iterator& parse
auto line_acct = split_props->get_account();
if (!line_acct)
{
if (m_settings.m_base_account)
split_props->set_account(m_settings.m_base_account);
else
{
// Oops - the user didn't select an Account column *and* we didn't get a default value either!
// Note if you get here this suggests a bug in the code!
auto error_message = _("No account column selected and no base account specified either.\n"
"This should never happen. Please report this as a bug.");
PINFO("User warning: %s", error_message);
auto errs = ErrMap { ErrPair { GncTransPropType::NONE, error_message},};
throw GncCsvImpParseError(_("Parse Error"), errs);
}
// Oops - the user didn't select an Account column *and* we didn't get a default value either!
// Note if you get here this suggests a bug in the code!
auto error_message = _("No account column selected and no base account specified either.\n"
"This should never happen. Please report this as a bug.");
PINFO("User warning: %s", error_message);
auto errs = ErrMap { ErrPair { GncTransPropType::NONE, error_message},};
throw GncCsvImpParseError(_("Parse Error"), errs);
}
/* If column parsing was successful, convert trans properties into a draft transaction. */