From 8b94e9a440638703b7a34f7eb763ad736dad4077 Mon Sep 17 00:00:00 2001 From: Christopher Lam Date: Thu, 6 Jul 2023 08:44:13 +0800 Subject: [PATCH] SCM must never be NULL It is assigned later on; nevertheless must never be NULL. It could be SCM_EOL. --- gnucash/gnome/dialog-report-style-sheet.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/gnucash/gnome/dialog-report-style-sheet.cpp b/gnucash/gnome/dialog-report-style-sheet.cpp index a0d8f97d75..135228bc91 100644 --- a/gnucash/gnome/dialog-report-style-sheet.cpp +++ b/gnucash/gnome/dialog-report-style-sheet.cpp @@ -87,9 +87,8 @@ static void dirty_same_stylesheet (gpointer key, gpointer val, gpointer data) { auto dirty_ss{static_cast(data)}; - SCM rep_ss = NULL; auto report{static_cast(val)}; - SCM func = NULL; + SCM func, rep_ss; func = scm_c_eval_string ("gnc:report-stylesheet"); if (scm_is_procedure (func)) @@ -378,7 +377,7 @@ gnc_style_sheet_select_dialog_edit_cb (GtkWidget *widget, gpointer user_data) ss_info * ssinfo; gchar * name; - SCM sheet_info = NULL; + SCM sheet_info; gtk_tree_model_get (model, &iter, COLUMN_NAME, &name, @@ -408,7 +407,7 @@ gnc_style_sheet_select_dialog_delete_cb (GtkWidget *widget, gpointer user_data) { ss_info * ssinfo; - SCM sheet_info = NULL; + SCM sheet_info; SCM remover; gtk_tree_model_get (model, &iter,