mirror of
https://github.com/Gnucash/gnucash.git
synced 2025-02-25 18:55:30 -06:00
csv-imp - add test for parse_date
This commit is contained in:
Geert Janssens
parent
598531f7e6
commit
8fba6e216d
@ -32,6 +32,15 @@ typedef struct
|
||||
{
|
||||
} Fixture;
|
||||
|
||||
typedef struct
|
||||
{
|
||||
int date_fmt;
|
||||
const gchar *date_str;
|
||||
int exp_year;
|
||||
int exp_month;
|
||||
int exp_day;
|
||||
} parse_date_data;
|
||||
|
||||
static void
|
||||
setup( Fixture *fixture, gconstpointer pData )
|
||||
{
|
||||
@ -71,24 +80,158 @@ static char* get_filepath(const char* filename, gboolean test_existence)
|
||||
/* parse_date_with_year
|
||||
time64 parse_date_with_year (const char* date_str, int format)// Local: 1:0:0
|
||||
*/
|
||||
/* static void
|
||||
test_parse_date_with_year (Fixture *fixture, gconstpointer pData)
|
||||
{
|
||||
}*/
|
||||
// Internal helper only - no tests.
|
||||
/* parse_date_without_year
|
||||
static time64 parse_date_without_year (const char* date_str, int format)// Local: 1:0:0
|
||||
*/
|
||||
/* static void
|
||||
test_parse_date_without_year (Fixture *fixture, gconstpointer pData)
|
||||
{
|
||||
}*/
|
||||
// Internal helper only - no tests.
|
||||
|
||||
/* parse_date
|
||||
time64 parse_date (const char* date_str, int format)// C: 14 in 7 SCM: 9 in 2 Local: 1:0:0
|
||||
*/
|
||||
/* static void
|
||||
static void
|
||||
test_parse_date (Fixture *fixture, gconstpointer pData)
|
||||
{
|
||||
}*/
|
||||
time64 rawtime = gnc_time_utc (NULL);
|
||||
struct tm *tm = gnc_gmtime (&rawtime);
|
||||
int curr_year = tm->tm_year;
|
||||
|
||||
|
||||
/* Note: tm_year = year - 1900 and tm_mon = 0-11
|
||||
* I'm writing the expected values as subtractions for easier
|
||||
* comparison with the date string under test
|
||||
*/
|
||||
parse_date_data test_dates[] =
|
||||
{
|
||||
// supported combinations -/.'
|
||||
{ 0, "2013-08-01", 2013 - 1900, 8 - 1, 1},
|
||||
{ 0, "2013-8-01", 2013 - 1900, 8 - 1, 1},
|
||||
{ 0, "2013-08-1", 2013 - 1900, 8 - 1, 1},
|
||||
{ 0, "2013-8-1", 2013 - 1900, 8 - 1, 1},
|
||||
{ 0, "13-08-01", 2013 - 1900, 8 - 1, 1},
|
||||
{ 0, "13-8-01", 2013 - 1900, 8 - 1, 1},
|
||||
{ 0, "13-08-1", 2013 - 1900, 8 - 1, 1},
|
||||
{ 0, "13-8-1", 2013 - 1900, 8 - 1, 1},
|
||||
{ 0, "2009/11/04", 2009 - 1900, 11 - 1, 4},
|
||||
{ 0, "1985.3.12", 1985 - 1900, 3 - 1, 12},
|
||||
{ 0, "3'6'8", 2003 - 1900, 6 - 1, 8},
|
||||
{ 0, "20130801", 2013 - 1900, 8 - 1, 1},
|
||||
{ 1, "01-08-2013", 2013 - 1900, 8 - 1, 1},
|
||||
{ 1, "01-8-2013", 2013 - 1900, 8 - 1, 1},
|
||||
{ 1, "1-08-2013", 2013 - 1900, 8 - 1, 1},
|
||||
{ 1, "1-8-2013", 2013 - 1900, 8 - 1, 1},
|
||||
{ 1, "01-08-13", 2013 - 1900, 8 - 1, 1},
|
||||
{ 1, "01-8-13", 2013 - 1900, 8 - 1, 1},
|
||||
{ 1, "1-08-13", 2013 - 1900, 8 - 1, 1},
|
||||
{ 1, "1-8-13", 2013 - 1900, 8 - 1, 1},
|
||||
{ 1, "04/11/2009", 2009 - 1900, 11 - 1, 4},
|
||||
{ 1, "12.3.1985", 1985 - 1900, 3 - 1, 12},
|
||||
{ 1, "8'6'3", 2003 - 1900, 6 - 1, 8},
|
||||
{ 1, "01082013", 2013 - 1900, 8 - 1, 1},
|
||||
{ 2, "08-01-2013", 2013 - 1900, 8 - 1, 1},
|
||||
{ 2, "8-01-2013", 2013 - 1900, 8 - 1, 1},
|
||||
{ 2, "08-1-2013", 2013 - 1900, 8 - 1, 1},
|
||||
{ 2, "8-1-2013", 2013 - 1900, 8 - 1, 1},
|
||||
{ 2, "08-01-13", 2013 - 1900, 8 - 1, 1},
|
||||
{ 2, "8-01-13", 2013 - 1900, 8 - 1, 1},
|
||||
{ 2, "08-1-13", 2013 - 1900, 8 - 1, 1},
|
||||
{ 2, "8-1-13", 2013 - 1900, 8 - 1, 1},
|
||||
{ 2, "11/04/2009", 2009 - 1900, 11 - 1, 4},
|
||||
{ 2, "3.12.1985", 1985 - 1900, 3 - 1, 12},
|
||||
{ 2, "6'8'3", 2003 - 1900, 6 - 1, 8},
|
||||
{ 2, "08012013", 2013 - 1900, 8 - 1, 1},
|
||||
{ 3, "01-08", curr_year, 8 - 1, 1},
|
||||
{ 3, "01-8", curr_year, 8 - 1, 1},
|
||||
{ 3, "1-08", curr_year, 8 - 1, 1},
|
||||
{ 3, "1-8", curr_year, 8 - 1, 1},
|
||||
{ 3, "04/11", curr_year, 11 - 1, 4},
|
||||
{ 3, "12.3", curr_year, 3 - 1, 12},
|
||||
{ 3, "8'6", curr_year, 6 - 1, 8},
|
||||
{ 4, "08-01", curr_year, 8 - 1, 1},
|
||||
{ 4, "8-01", curr_year, 8 - 1, 1},
|
||||
{ 4, "08-1", curr_year, 8 - 1, 1},
|
||||
{ 4, "8-1", curr_year, 8 - 1, 1},
|
||||
{ 4, "11/04", curr_year, 11 - 1, 4},
|
||||
{ 4, "3.12", curr_year, 3 - 1, 12},
|
||||
{ 4, "6'8", curr_year, 6 - 1, 8},
|
||||
|
||||
// ambiguous date formats
|
||||
// current parser doesn't know how to disambiguate
|
||||
// and hence refuses to parse
|
||||
// can possibly improved with a smarter parser
|
||||
{ 0, "130801", -1, -1, -1},
|
||||
{ 1, "010813", -1, -1, -1},
|
||||
{ 2, "080113", -1, -1, -1},
|
||||
{ 3, "0108", -1, -1, -1},
|
||||
{ 4, "0801", -1, -1, -1},
|
||||
|
||||
// Combinations that don't make sense
|
||||
// but can still be entered by a user
|
||||
// Should ideally all result in refusal to parse...
|
||||
{ 0, "08-01", -1, -1, -1},
|
||||
{ 0, "0801", -1, -1, -1},
|
||||
{ 1, "01-08", -1, -1, -1},
|
||||
{ 1, "0108", -1, -1, -1},
|
||||
{ 2, "08-01", -1, -1, -1},
|
||||
{ 2, "0801", -1, -1, -1},
|
||||
{ 3, "01-08-2013", curr_year, 8 - 1, 1}, // BAD behavior !
|
||||
{ 3, "01-08-13", curr_year, 8 - 1, 1}, // BAD behavior !
|
||||
{ 3, "08-08-08", curr_year, 8 - 1, 8}, // BAD behavior !
|
||||
{ 3, "01082013", -1, -1, -1},
|
||||
{ 3, "010813", -1, -1, -1},
|
||||
{ 3, "20130108", -1, -1, -1},
|
||||
{ 4, "08-01-2013", curr_year, 8 - 1, 1}, // BAD behavior !
|
||||
{ 4, "08-01-13", curr_year, 8 - 1, 1}, // BAD behavior !
|
||||
{ 4, "2013-08-01", -1, -1, -1},
|
||||
{ 4, "09-08-01", curr_year, 9 - 1, 8}, // BAD behavior !
|
||||
{ 4, "08012013", -1, -1, -1},
|
||||
{ 4, "080113", -1, -1, -1},
|
||||
{ 4, "20130801", -1, -1, -1},
|
||||
|
||||
// Sentinel to mark the end of available tests
|
||||
{ NULL, 0, 0, 0, 0},
|
||||
|
||||
};
|
||||
int i = 0;
|
||||
|
||||
gnc_tm_free(tm);
|
||||
while (test_dates[i].date_str)
|
||||
{
|
||||
gboolean success = TRUE;
|
||||
int got_year = 0, got_month = 0, got_day = 0;
|
||||
|
||||
rawtime = parse_date (test_dates[i].date_str, test_dates[i].date_fmt);
|
||||
if (rawtime == -1)
|
||||
got_year = got_month = got_day = -1;
|
||||
else
|
||||
{
|
||||
tm = gnc_gmtime (&rawtime);
|
||||
got_year = tm->tm_year;
|
||||
got_month = tm->tm_mon;
|
||||
got_day = tm->tm_mday;
|
||||
gnc_tm_free(tm);
|
||||
}
|
||||
|
||||
if ((got_year != test_dates[i].exp_year) ||
|
||||
(got_month != test_dates[i].exp_month) ||
|
||||
(got_day != test_dates[i].exp_day))
|
||||
{
|
||||
g_error ("Parse_date failed for date '%s' and format '%d'.\n"
|
||||
"Expected result: year %d, month %d, day %d\n"
|
||||
"Obtained result: year %d, month %d, day %d",
|
||||
test_dates[i].date_str,
|
||||
test_dates[i].date_fmt,
|
||||
test_dates[i].exp_year,
|
||||
test_dates[i].exp_month,
|
||||
test_dates[i].exp_day,
|
||||
got_year, got_month, got_day);
|
||||
}
|
||||
|
||||
i++;
|
||||
}
|
||||
|
||||
|
||||
}
|
||||
/* gnc_csv_parse_data_free
|
||||
void gnc_csv_parse_data_free (GncCsvParseData* parse_data)// C: 3 in 1 Local: 0:0:0
|
||||
*/
|
||||
@ -208,7 +351,7 @@ test_suite_gnc_csv_model (void)
|
||||
|
||||
// GNC_TEST_ADD (suitename, "parse date with year", Fixture, NULL, setup, test_parse_date_with_year, teardown);
|
||||
// GNC_TEST_ADD (suitename, "parse date without year", Fixture, NULL, setup, test_parse_date_without_year, teardown);
|
||||
// GNC_TEST_ADD (suitename, "parse date", Fixture, NULL, setup, test_parse_date, teardown);
|
||||
GNC_TEST_ADD (suitename, "parse date", Fixture, NULL, NULL, test_parse_date, NULL);
|
||||
// GNC_TEST_ADD (suitename, "gnc csv parse data free", Fixture, NULL, setup, test_gnc_csv_parse_data_free, teardown);
|
||||
// GNC_TEST_ADD (suitename, "gnc csv convert encoding", Fixture, NULL, setup, test_gnc_csv_convert_encoding, teardown);
|
||||
// GNC_TEST_ADD (suitename, "gnc csv load file", Fixture, NULL, setup, test_gnc_csv_load_file, teardown);
|
||||
|
||||
Loading…
Reference in New Issue
Block a user