From 92071e88441afc5af412274dec921354c38608ee Mon Sep 17 00:00:00 2001 From: John Ralls Date: Sun, 5 Mar 2023 10:14:20 -0800 Subject: [PATCH] [c++options] Fix leak. --- libgnucash/engine/gnc-optiondb.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libgnucash/engine/gnc-optiondb.cpp b/libgnucash/engine/gnc-optiondb.cpp index 98c98688f5..5309ae7ac8 100644 --- a/libgnucash/engine/gnc-optiondb.cpp +++ b/libgnucash/engine/gnc-optiondb.cpp @@ -1261,9 +1261,7 @@ const char* gnc_option_db_lookup_string_value(GncOptionDB* odb, const char* section, const char* name) { auto value{odb->lookup_string_option(section, name)}; - if (value.empty()) - return nullptr; - return strdup(value.c_str()); + return value.empty() ? nullptr : strdup(value.c_str()); } void