IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Bug 797546 - Autocomplete not updated when account names changed

Browse Source 
If an account name is changed, the autocomplete list store was updated
but the hash table was not so this change checks for the name change
and updates the hash table. Also fixed was changing the account from /
to a placeholder account which will show or hide the account.
This commit is contained in:
Robert Fewell
2020-01-09 14:47:43 +00:00
parent 3c6ad3ae82
commit 936e2bf371
1 changed files with 17 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
gnucash/gnome-utils/account-quickfill.c
View File

@@ -291,6 +291,7 @@ listen_for_account_events (QofInstance *entity, QofEventId event_type,
* store. Otherwise its a simple update of the name string. */
for (tmp = data.refs; tmp; tmp = g_list_next(tmp))
{
gchar *old_name, *new_name;
path = gtk_tree_row_reference_get_path(tmp->data);
gtk_tree_row_reference_free(tmp->data);
if (!gtk_tree_model_get_iter(GTK_TREE_MODEL(qfb->list_store),
@@ -302,20 +303,31 @@ listen_for_account_events (QofInstance *entity, QofEventId event_type,
gtk_tree_path_free(path);
gtk_tree_model_get(GTK_TREE_MODEL(qfb->list_store), &iter,
ACCOUNT_POINTER, &account,
ACCOUNT_NAME, &old_name,
-1);
new_name = gnc_get_account_name_for_register(account);
/* check if the name has changed */
match = gnc_quickfill_get_string_match (qf, old_name);
if (match && (g_strcmp0 (old_name, new_name) != 0))
gnc_quickfill_remove (qf, old_name, QUICKFILL_ALPHA);
if (qfb->dont_add_cb &&
qfb->dont_add_cb(account, qfb->dont_add_data))
{
gnc_quickfill_remove (qf, new_name, QUICKFILL_ALPHA);
gtk_list_store_remove(qfb->list_store, &iter);
}
else
{
gchar *aname = gnc_get_account_name_for_register(account);
gnc_quickfill_insert (qf, new_name, QUICKFILL_ALPHA);
gtk_list_store_set(qfb->list_store, &iter,
ACCOUNT_NAME, aname,
ACCOUNT_NAME, new_name,
-1);
g_free(aname);
}
g_free (old_name);
g_free (new_name);
}
/* Any accounts that weren't found in the tree are accounts that
@@ -331,6 +343,7 @@ listen_for_account_events (QofInstance *entity, QofEventId event_type,
continue;
}
}
gnc_quickfill_insert (qf, name, QUICKFILL_ALPHA);
gtk_list_store_append (qfb->list_store, &iter);
gtk_list_store_set (qfb->list_store, &iter,
ACCOUNT_NAME, name,
@@ -366,6 +379,7 @@ listen_for_account_events (QofInstance *entity, QofEventId event_type,
case QOF_EVENT_ADD:
DEBUG("add %s", name);
if (qfb->dont_add_cb &&
qfb->dont_add_cb(account, qfb->dont_add_data))
break;