IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Bug 797897 - Cannot select multiple accounts in Tax Report Options

Browse Source 
Multi selection was disabled for Bug 518833, 27/01/2019 but the select
sub accounts button was left giving the impression of multi selection.

I have enabled the multi selection for the tree view and while testing
all accounts selected were updated with the selected tax option.
This commit is contained in:
Robert Fewell 2020-09-24 11:36:55 +01:00
parent a926991d75
commit 95b502ea96
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gnucash/gnome/dialog-tax-info.c
View File

@ -930,8 +930,7 @@ gnc_tax_info_account_changed_cb (GtkTreeSelection *selection,
case 1: case 1:
/* Get the account. This view is set for multiple selection, so we /* Get the account. This view is set for multiple selection, so we
can only get a list of accounts. 1-25-19: The dialog does not work can only get a list of accounts. */
for multiple accounts so it was changed to single selection */
view = GNC_TREE_VIEW_ACCOUNT(ti_dialog->account_treeview); view = GNC_TREE_VIEW_ACCOUNT(ti_dialog->account_treeview);
accounts = gnc_tree_view_account_get_selected_accounts (view); accounts = gnc_tree_view_account_get_selected_accounts (view);
if (accounts == NULL) if (accounts == NULL)
@ -941,7 +940,7 @@ gnc_tax_info_account_changed_cb (GtkTreeSelection *selection,
return; return;
} }
account_to_gui (ti_dialog, accounts->data); account_to_gui (ti_dialog, accounts->data);
g_list_free(accounts); g_list_free (accounts);
gnc_tax_info_set_changed (ti_dialog, FALSE); gnc_tax_info_set_changed (ti_dialog, FALSE);
break; break;
@ -1423,7 +1422,7 @@ gnc_tax_info_dialog_create (GtkWidget * parent, TaxInfoDialog *ti_dialog)
ti_dialog->account_treeview = GTK_WIDGET(tree_view); ti_dialog->account_treeview = GTK_WIDGET(tree_view);
selection = gtk_tree_view_get_selection (tree_view); selection = gtk_tree_view_get_selection (tree_view);
gtk_tree_selection_set_mode (selection, GTK_SELECTION_SINGLE); gtk_tree_selection_set_mode (selection, GTK_SELECTION_MULTIPLE);
g_signal_connect (G_OBJECT (selection), "changed", g_signal_connect (G_OBJECT (selection), "changed",
G_CALLBACK (gnc_tax_info_account_changed_cb), G_CALLBACK (gnc_tax_info_account_changed_cb),
ti_dialog); ti_dialog);