IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

[report-utilities] improve (gnc:account-get-comm-balance-at-date)

Browse Source 
This improves (gnc:account-get-comm-balance-at-date) to
use (xaccAccountBalanceAsOfDate) instead of cycling through a split
list.

This function is used in numerous charts and should speed them up
tremendously.
This commit is contained in:
Christopher Lam 2018-09-12 18:26:48 +08:00
parent 2832b8e63c
commit 984501e951
1 changed files with 13 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
gnucash/report/report-system/report-utilities.scm
View File

@ -392,42 +392,20 @@ construct gnc:make-gnc-monetary and use gnc:monetary->string instead.")
;; This works similar as above but returns a commodity-collector,
;; thus takes care of children accounts with different currencies.
;;
;; Also note that the commodity-collector contains <gnc:numeric>
;; values rather than double values.
(define (gnc:account-get-comm-balance-at-date account
date include-children?)
(define (gnc:account-get-comm-balance-at-date
account date include-children?)
(let ((balance-collector (gnc:make-commodity-collector))
(query (qof-query-create-for-splits))
(splits #f))
(if include-children?
(for-each
(lambda (x)
(balance-collector 'merge x #f))
(gnc:account-map-descendants
(lambda (child)
(gnc:account-get-comm-balance-at-date child date #f))
account)))
(qof-query-set-book query (gnc-get-current-book))
(xaccQueryAddSingleAccountMatch query account QOF-QUERY-AND)
(xaccQueryAddDateMatchTT query #f date #t date QOF-QUERY-AND)
(qof-query-set-sort-order query
(list SPLIT-TRANS TRANS-DATE-POSTED)
(list QUERY-DEFAULT-SORT)
'())
(qof-query-set-sort-increasing query #t #t #t)
(qof-query-set-max-results query 1)
(set! splits (qof-query-run query))
(qof-query-destroy query)
(if (and splits (not (null? splits)))
(balance-collector 'add
(xaccAccountGetCommodity account)
(xaccSplitGetBalance (car splits))))
balance-collector))
(accounts (cons account
(if include-children?
(gnc-account-get-descendants account)
'()))))
(for-each
(lambda (acct)
(balance-collector 'add
(xaccAccountGetCommodity acct)
(xaccAccountGetBalanceAsOfDate acct date)))
accounts)
balance-collector))
;; Calculate the increase in the balance of the account in terms of
;; "value" (as opposed to "amount") between the specified dates.