IntenseFinance/gnucash
3
0 Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2026-11-02 20:30:45 -06:00
Code Issues Packages Projects Releases Wiki Activity

[qoflog.cpp] plug GKeyFile leak on error

Browse Source 
also prevent std::string copies
This commit is contained in:
Christopher Lam committed 2026-10-14 07:50:11 +08:00
1 parent 5d35e6993e
commit 9e39744aac
1 file changed
+4 -3
Download Patch File Download Diff File Expand all files Collapse all files
libgnucash/engine/qoflog.cpp
+4 -3
View File
@@ -304,11 +304,11 @@ qof_log_set_level(QofLogModule log_module, QofLogLevel level)
auto module_parts = split_domain(log_module);
auto module = get_modules();
for (auto part : module_parts)
for (const auto& part : module_parts)
{
auto iter = std::find_if(module->m_children.begin(),
module->m_children.end(),
[part](auto& child){
[part](const auto& child){
return child && part == child->m_name;
});
if (iter == module->m_children.end())
@@ -348,7 +348,7 @@ qof_log_check(QofLogModule domain, QofLogLevel level)
{
auto iter = std::find_if(module->m_children.begin(),
module->m_children.end(),
[part](auto& child) {
[part](const auto& child) {
return child && part == child->m_name; });
if (iter == module->m_children.end())
@@ -428,6 +428,7 @@ qof_log_parse_log_config(const char *filename)
{
g_warning("unable to parse [%s]: %s", filename, err->message);
g_error_free(err);
g_key_file_free(conf);
return;
}