From 9f6d495ca1b37106fca6ec6dd2963b518596e08a Mon Sep 17 00:00:00 2001 From: John Ralls Date: Sun, 3 Jul 2022 13:07:52 -0700 Subject: [PATCH] Fix use-after-free crash in utest-Invoice. --- libgnucash/engine/test/utest-Invoice.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libgnucash/engine/test/utest-Invoice.c b/libgnucash/engine/test/utest-Invoice.c index d8323a02dd..65fe389d1f 100644 --- a/libgnucash/engine/test/utest-Invoice.c +++ b/libgnucash/engine/test/utest-Invoice.c @@ -86,6 +86,11 @@ teardown( Fixture *fixture, gconstpointer pData ) gncInvoiceBeginEdit(fixture->invoice); gncInvoiceDestroy(fixture->invoice); + xaccAccountBeginEdit(fixture->account); + xaccAccountDestroy(fixture->account); + xaccAccountBeginEdit(fixture->account2); + xaccAccountDestroy(fixture->account2); + if (data->is_cust_doc) { gncCustomerBeginEdit(fixture->customer); @@ -97,10 +102,6 @@ teardown( Fixture *fixture, gconstpointer pData ) gncVendorDestroy(fixture->vendor); } - xaccAccountBeginEdit(fixture->account); - xaccAccountDestroy(fixture->account); - xaccAccountBeginEdit(fixture->account2); - xaccAccountDestroy(fixture->account2); gnc_commodity_destroy(fixture->commodity); qof_book_destroy( fixture->book );