IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

[view-column] refactor to remove reference to gnc:last-captured-error

Browse Source 
because gnc:last-captured-error is a global var, and should be removed.
This commit is contained in:
Christopher Lam 2020-12-17 08:46:58 +08:00
parent 5f2a2f4626
commit a1cfdeb601
1 changed files with 11 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
gnucash/report/reports/standard/view-column.scm
View File

@ -116,21 +116,17 @@
(gnc:report-set-stylesheet!
subreport (gnc:report-stylesheet report))
;; render the report body ... hopefully this will DTRT
;; if there is an error, then dump a backtrace and print
;; an error message
;; and cache when it's ok to cache.
(if (not (gnc:backtrace-if-exception
(lambda ()
(gnc:html-table-cell-append-objects!
contents-cell (gnc:report-render-html subreport #f))
#t)))
(gnc:html-table-cell-append-objects!
contents-cell
(gnc:make-html-text
(gnc:html-markup-h3 (G_ "Report error"))
(G_ "An error occurred while running the report.")
(gnc:html-markup "pre" gnc:last-captured-error))))
;; render the report body ... capture error if report crashes.
(gnc:html-table-cell-append-objects!
contents-cell
(match (gnc:apply-with-error-handling
(lambda () (gnc:report-render-html subreport #f)) '())
((html #f) html)
((_ captured-error)
(gnc:make-html-text
(gnc:html-markup-h3 (G_ "Report error"))
(G_ "An error occurred while running the report.")
(gnc:html-markup "pre" captured-error)))))
;; increment the alloc number for each occupied row
(let loop ((row current-row-num))