IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Scott Oonk's patch to simplify the keyboard selection in

Browse Source 
gnucash-sheet.  Fixes a problem where selection does not work
correctly when holding 'shift' and hitting the left arrow key.


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@11892 57a11ea4-9604-0410-9ed3-97b8803252fd
This commit is contained in:
David Hampton
2005-11-09 22:38:08 +00:00
parent 3e9a2cd797
commit a5b0d74d41
2 changed files with 6 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@@ -1,5 +1,10 @@
2005-11-09 Scott Oonk <scott.oonk@gmail.com> 2005-11-09 Scott Oonk <scott.oonk@gmail.com>
* src/register/register-gnome/gnucash-sheet.c: This patch
simplifies the keyboard selection in gnucash-sheet. Fixes a
problem where selection does not work correctly when holding
'shift' and hitting the left arrow key.
* src/register/register-gnome/gnucash-item-edit.[ch]: This patch * src/register/register-gnome/gnucash-item-edit.[ch]: This patch
simplifies the mouse selection logic in gnucash-item-edit. It simplifies the mouse selection logic in gnucash-item-edit. It
also fixes a problem where selection with the mouse does not work also fixes a problem where selection with the mouse does not work

56
src/register/register-gnome/gnucash-sheet.c
View File

@@ -1567,7 +1567,6 @@ gnucash_sheet_key_press_event (GtkWidget *widget, GdkEventKey *event)
CellBlock *header; CellBlock *header;
gboolean pass_on = FALSE; gboolean pass_on = FALSE;
gboolean abort_move; gboolean abort_move;
gboolean set_selection = TRUE;
VirtualLocation cur_virt_loc; VirtualLocation cur_virt_loc;
VirtualLocation new_virt_loc; VirtualLocation new_virt_loc;
gncTableTraversalDir direction = 0; gncTableTraversalDir direction = 0;
@@ -1667,7 +1666,6 @@ gnucash_sheet_key_press_event (GtkWidget *widget, GdkEventKey *event)
case GDK_Alt_L: case GDK_Alt_L:
case GDK_Alt_R: case GDK_Alt_R:
pass_on = TRUE; pass_on = TRUE;
set_selection = FALSE;
break; break;
default: default:
if (gnucash_sheet_clipboard_event(sheet, event)) if (gnucash_sheet_clipboard_event(sheet, event))
@@ -1688,64 +1686,12 @@ gnucash_sheet_key_press_event (GtkWidget *widget, GdkEventKey *event)
break; break;
} }
if (event->length > 0)
set_selection = FALSE;
break; break;
} }
/* Forward the keystroke to the input line */ /* Forward the keystroke to the input line */
if (pass_on) if (pass_on)
{ return gtk_widget_event (sheet->entry, (GdkEvent *) event);
GtkEditable *editable;
gboolean extend_selection;
gboolean result;
gint current_pos;
gint start_sel;
gint end_sel;
gint new_pos;
editable = GTK_EDITABLE(sheet->entry);
current_pos = gtk_editable_get_position (editable);
extend_selection = event->state & GDK_SHIFT_MASK;
if (extend_selection && set_selection)
{
gtk_editable_get_selection_bounds (editable, &start_sel, &end_sel);
}
else
{
start_sel = 0;
end_sel = 0;
}
sheet->input_cancelled = FALSE;
result = gtk_widget_event (sheet->entry, (GdkEvent *) event);
sheet->input_cancelled = FALSE;
new_pos = gtk_editable_get_position (editable);
if (extend_selection && set_selection)
{
if (start_sel == end_sel)
{
start_sel = current_pos;
end_sel = new_pos;
}
else if (current_pos == start_sel)
start_sel = new_pos;
else
end_sel = new_pos;
}
if (set_selection && (start_sel != end_sel))
gtk_editable_select_region(editable, start_sel, end_sel);
return result;
}
abort_move = gnc_table_traverse_update (table, cur_virt_loc, abort_move = gnc_table_traverse_update (table, cur_virt_loc,
direction, &new_virt_loc); direction, &new_virt_loc);