various reports: use more efficient report-utilities.scm functions

instead of delete-duplicates

gnucash/report/business-reports/customer-summary.scm

@@ -292,9 +292,7 @@
          (expense-accounts (opt-val pagename-expenseaccounts optname-expenseaccounts))
          (sales-accounts (opt-val pagename-incomeaccounts optname-incomeaccounts))
          (all-accounts (append sales-accounts expense-accounts))
-         (commodities (delete-duplicates
+         (commodities (gnc:accounts-get-commodities all-accounts #f))
-                       (map xaccAccountGetCommodity all-accounts)
-                       gnc-commodity-equiv))
          (commodities>1? (> (length commodities) 1))
          (book (gnc-get-current-book))
          (date-format (gnc:options-fancy-date book))

gnucash/report/standard-reports/balance-forecast.scm

@@ -167,8 +167,7 @@ date point, a projected minimum balance including scheduled transactions."))
           (accum (gnc:make-commodity-collector))
           (exchange-fn (gnc:case-exchange-time-fn
                         price currency
-                        (delete-duplicates! (map xaccAccountGetCommodity accounts)
+                        (gnc:accounts-get-commodities accounts #f)
-                                            gnc-commodity-equiv)
                         to-date #f #f))
           (accounts-balancelist
            (map

gnucash/report/standard-reports/balsheet-pnl.scm

@@ -802,12 +802,7 @@ also show overall period profit & loss."))
          ;; missing price, say so.
          (get-exchange-rates-fn
           (lambda (accounts col-idx)
-            (let ((commodities (delete
+            (let ((commodities (gnc:accounts-get-commodities accounts common-currency))
-                                common-currency
-                                (delete-duplicates
-                                 (map xaccAccountGetCommodity accounts)
-                                 gnc-commodity-equal)
-                                gnc-commodity-equal))
                   (cell (gnc:make-html-text)))
               (for-each
                (lambda (commodity)

gnucash/report/standard-reports/category-barchart.scm

@@ -375,8 +375,7 @@ developing over time"))
                                 (xaccSplitGetAmount s))))))))
              ;; all selected accounts (of report-specific type), *and*
              ;; their descendants (of any type) need to be scanned.
-             (delete-duplicates
+             (gnc:accounts-and-all-descendants accounts)))
-              (append accounts (gnc:acccounts-get-all-subaccounts accounts)))))
 
           ;; Creates the <balance-list> to be used in the function
           ;; below.

gnucash/report/standard-reports/daily-reports.scm

@@ -226,21 +226,9 @@
           ;; add accounts to the query (include subaccounts 
           ;; if requested)
 	  (gnc:report-percent-done 25)
-          (if dosubs? 
+          (if dosubs?
-              (let ((subaccts '()))
+              (set! accounts
-                (for-each 
+                (gnc:accounts-and-all-descendants accounts)))
-                 (lambda (acct)
-                   (let ((this-acct-subs 
-                          (gnc-account-get-descendants-sorted acct)))
-                     (if (list? this-acct-subs)
-                         (set! subaccts 
-                               (append subaccts this-acct-subs)))))
-                 accounts)
-                ;; Beware: delete-duplicates is an O(n^2)
-                ;; algorithm. More efficient method: sort the list,
-                ;; then use a linear algorithm.
-                (set! accounts
-                      (delete-duplicates (append accounts subaccts)))))
 	  (gnc:report-percent-done 30)
           
           (xaccQueryAddAccountMatch query accounts QOF-GUID-MATCH-ANY QOF-QUERY-AND)