IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Bug #593479: Ensure not to accidentally delete our main account file.

Browse Source 
Original patch by Tim Retout who writes:

strptime is passed (name + pathlen + 1) as the string to search.  However, when
looking at the main account file, strlen(name) == pathlen, so strptime is
looking at the point just past the end of name.

Sometimes this will be parseable by strptime, and this leads to the account
file being unlinked.

git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@19638 57a11ea4-9604-0410-9ed3-97b8803252fd
This commit is contained in:
Christian Stimming 2010-10-05 18:07:38 +00:00
parent 012d76aa53
commit ab0dd2cca7
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/backend/xml/gnc-backend-xml.c
View File

@ -834,16 +834,24 @@ gnc_xml_be_remove_old_files(FileBackend *be)
continue; continue;
name = g_build_filename(be->dirname, dent, (gchar*)NULL); name = g_build_filename(be->dirname, dent, (gchar*)NULL);
len = strlen(name) - 4; len = strlen(name);
/* Never remove the current data file itself */ /* Never remove the current data file itself */
if (g_strcmp0(name, be->fullpath) == 0) if (g_strcmp0(name, be->fullpath) == 0)
continue; continue;
/* Is this file associated with the current data file */ /* Is this file associated with the current data file?
if (strncmp(name, be->fullpath, pathlen) == 0) * Additionally, the invariants for the pointer arithmetic
* must hold: String length long enough to contain the suffix,
* and string length large enough so that strptime below will
* not be passed a pointer outside of our string. (Otherwise
* the result of strptime might be parseable and the main data
* file is deleted, #593479) */
if ((strncmp(name, be->fullpath, pathlen) == 0)
&& (len >= 4)
&& (len > pathlen))
{ {
if (safe_strcmp(name + len, ".LNK") == 0) if (safe_strcmp(name + len - 4, ".LNK") == 0)
{ {
/* Is a lock file. Skip the active lock file */ /* Is a lock file. Skip the active lock file */
if ((safe_strcmp(name, be->linkfile) != 0) && if ((safe_strcmp(name, be->linkfile) != 0) &&