IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Bug 798461 - balance sheet shows positions with zero balances

Browse Source 
despite report options

This occurs when accounts with different currencies or commodities
are being rolled up to a higher level of subaccounts. Fixed by
removing commodities with zero totals from commoditylist when
"omit zero balance figures" option is selected.
This commit is contained in:
Vincent Dawans
2023-04-21 15:20:36 -07:00
parent 4a5b897d89
commit b3899f77a1
3 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gnucash/report/html-acct-table.scm
View File

@@ -1023,6 +1023,8 @@
(omit-bal . #f)))
(bal-sym (assq-ref bal-syms bal-method))
(comm-amt (get-val env bal-sym)))
(when (eq? zero-mode 'omit-balance)
(comm-amt 'remove-zeros #f #f))
(cond
((and (eq? zero-mode 'omit-balance)
(gnc-commodity-collector-allzero? comm-amt)) #f)

3
gnucash/report/report-utilities.scm
View File

@@ -365,6 +365,8 @@
(total (if pair ((cadr pair) 'total #f) 0)))
(gnc:make-gnc-monetary c (if sign? (- total) total))))
(define (not-zero? l) (not (zero? ((cadr l) 'total #f))))
;; Dispatch function
(lambda (action commodity amount)
(case action
@@ -377,6 +379,7 @@
((reset) (set! commoditylist '()))
((getpair) (getpair commodity amount))
((getmonetary) (getmonetary commodity amount))
((remove-zeros) (set! commoditylist (filter not-zero? commoditylist)))
((list) commoditylist) ; this one is only for internal use
(else (gnc:warn "bad commodity-collector action: " action))))))

11
gnucash/report/test/test-report-utilities.scm
View File

@@ -261,6 +261,17 @@
(coll-A 'add GBP -1)
(test-equal "gnc-commodity-collector does not round inappropriately"
'(("GBP" . 0))
(collector->list coll-A))
;; the following tests the remove-zeros action
(coll-A 'add USD 1)
(coll-A 'add EUR 0)
(test-equal "gnc-commodity-collector before remove-zeros"
'(("EUR" . 0) ("USD" . 1) ("GBP" . 0))
(collector->list coll-A))
(coll-A 'remove-zeros #f #f)
(test-equal "gnc-commodity-collector after remove-zeros"
'(("USD" . 1))
(collector->list coll-A)))
(teardown)))