IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-16 10:15:22 -06:00
Code Issues Packages Projects Releases Wiki Activity

[gnc-pricedb] gnc_price_list_equal: avoid 4 g_list_length calls

Browse Source
This commit is contained in:
Christopher Lam 2021-10-18 22:30:40 +08:00
parent 23e528f51a
commit b480600dc8
1 changed files with 17 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
libgnucash/engine/gnc-pricedb.c
View File

@ -796,26 +796,30 @@ gnc_price_list_destroy(PriceList *prices)
gboolean
gnc_price_list_equal(PriceList *prices1, PriceList *prices2)
{
GList *n1, *n2;
GList *n1 = prices1;
GList *n2 = prices2;
if (prices1 == prices2) return TRUE;
if (g_list_length (prices1) < g_list_length (prices2))
while (n1 || n2)
{
PINFO ("prices2 has extra prices");
return FALSE;
}
if (g_list_length (prices1) > g_list_length (prices2))
{
PINFO ("prices1 has extra prices");
return FALSE;
}
for (n1 = prices1, n2 = prices2; n1 ; n1 = n1->next, n2 = n2->next)
if (!n1)
{
PINFO ("prices2 has extra prices");
return FALSE;
}
if (!n2)
{
PINFO ("prices1 has extra prices");
return FALSE;
}
if (!gnc_price_equal (n1->data, n2->data))
return FALSE;
n1 = n1->next;
n2 = n2->next;
};
return TRUE;
}