IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Delete action on account page not disabled on edits

Browse Source 
When the notes or description cells are edited, the toolbar delete
account action was not being disabled and so when you tried to deleted
some text the account was deleted instead.

Fixed by specifying correct action group and using it.
This commit is contained in:
Robert Fewell 2023-02-21 09:52:11 +00:00
parent a84f191ed8
commit b59bf0b633
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gnucash/gnome-utils/gnc-main-window.cpp
View File

@ -3526,8 +3526,9 @@ gnc_main_window_find_action_in_group (GncMainWindow *window,
g_return_val_if_fail (action_name != nullptr, nullptr);
auto action_group = gtk_widget_get_action_group (GTK_WIDGET(window), group_name);
if (action_group)
action = g_action_map_lookup_action (G_ACTION_MAP(window), action_name);
action = g_action_map_lookup_action (G_ACTION_MAP(action_group), action_name);
return action;
}

12
gnucash/gnome/gnc-plugin-page-account-tree.c
View File

@ -598,9 +598,9 @@ static void
gnc_plugin_page_account_editing_started_cd (gpointer various, GncPluginPageRegister *page)
{
GncPluginPage *plugin_page = GNC_PLUGIN_PAGE(page);
GAction *action = gnc_main_window_find_action (GNC_MAIN_WINDOW(plugin_page->window),
"EditDeleteAccountAction");
GAction *action = gnc_main_window_find_action_in_group (GNC_MAIN_WINDOW(plugin_page->window),
"GncPluginPageAccountTreeActions",
"EditDeleteAccountAction");
if (action != NULL)
g_simple_action_set_enabled (G_SIMPLE_ACTION(action), FALSE);
}
@ -609,9 +609,9 @@ static void
gnc_plugin_page_account_editing_finished_cb (gpointer various, GncPluginPageRegister *page)
{
GncPluginPage *plugin_page = GNC_PLUGIN_PAGE(page);
GAction *action = gnc_main_window_find_action (GNC_MAIN_WINDOW(plugin_page->window),
"EditDeleteAccountAction");
GAction *action = gnc_main_window_find_action_in_group (GNC_MAIN_WINDOW(plugin_page->window),
"GncPluginPageAccountTreeActions",
"EditDeleteAccountAction");
if (action != NULL)
g_simple_action_set_enabled (G_SIMPLE_ACTION(action), TRUE);
}