IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

[gnc-recurrence.c] avoid O(N^2) children traversal

Browse Source 
* each loop iteration called g_list_length and g_list_nth_data

better to forloop scan children instead
This commit is contained in:
Christopher Lam 2021-02-22 18:11:53 +08:00
parent 910da534bf
commit b73cacd58c
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
gnucash/gnome-utils/gnc-recurrence.c
View File

@ -517,20 +517,15 @@ GList *
gnc_recurrence_comp_get_list(GncRecurrenceComp *grc) gnc_recurrence_comp_get_list(GncRecurrenceComp *grc)
{ {
GList *rlist = NULL, *children; GList *rlist = NULL, *children;
gint i;
children = gtk_container_get_children(GTK_CONTAINER(grc->vbox)); children = gtk_container_get_children(GTK_CONTAINER(grc->vbox));
for (i = 0; i < g_list_length(children); i++) for (GList *n = children; n; n = n->next)
{ {
GncRecurrence *gr; const Recurrence *r = gnc_recurrence_get (GNC_RECURRENCE (n->data));
const Recurrence *r; rlist = g_list_prepend (rlist, (gpointer)r);
gr = GNC_RECURRENCE(g_list_nth_data(children, i));
r = gnc_recurrence_get(gr);
rlist = g_list_append(rlist, (gpointer)r);
} }
g_list_free(children); g_list_free(children);
return rlist; return g_list_reverse (rlist);
} }