Adding KvpValueImpl test suite

src/libqof/qof/kvp-value.hpp

@@ -35,6 +35,16 @@ extern "C"
 #endif
 #include <boost/variant.hpp>
 
+/**
+ * KvpValueImpl should generally not be used on the stack because its
+ * destructor frees its contents, and it doesn't know anything
+ * about move semantics. Cases such as
+ *     KvpValueImpl v1;
+ *     auto guid = guid_new ();
+ *     v1 = KvpValueImpl {guid};
+ * fail because the third line deletes the guid in KvpValueImpl's destructor.
+ * Passing by value has similar problems.
+ */
 struct KvpValueImpl
 {
     public:

src/libqof/qof/test/Makefile.am

@@ -48,3 +48,23 @@ test_qof_CPPFLAGS = \
 	-DTESTPROG=test_qof \
 	-I$(top_srcdir)/lib/libc \
 	${GLIB_CFLAGS}
+
+if WITH_GOOGLE_TEST
+test_kvp_value_SOURCES = \
+    $(top_srcdir)/$(MODULEPATH)/kvp-value.cpp \
+    $(GTEST_ROOT)/src/gtest_main.cc \
+	test-kvp-value.cpp
+test_kvp_value_LDADD = \
+	$(top_builddir)/$(MODULEPATH)/libgnc-qof.la \
+    $(top_builddir)/src/test-core/libgtest.a \
+    $(GLIB_LIBS) \
+	$(BOOST_LDFLAGS)
+test_kvp_value_CPPFLAGS = \
+    -I$(GTEST_HEADERS) \
+    -I$(top_srcdir)/$(MODULEPATH) \
+    $(BOOST_CPPFLAGS) \
+    $(GLIB_CFLAGS) 
+
+check_PROGRAMS += test_kvp_value
+
+endif

src/libqof/qof/test/test-kvp-value.cpp

@@ -0,0 +1,90 @@
+/********************************************************************
+ * test-kvp-value.cpp: A Google Test suite for kvp-value impl.      *
+ * Copyright 2014 Aaron Laws <dartme18@gmail.com>                   *
+ *                                                                  *
+ * This program is free software; you can redistribute it and/or    *
+ * modify it under the terms of the GNU General Public License as   *
+ * published by the Free Software Foundation; either version 2 of   *
+ * the License, or (at your option) any later version.              *
+ *                                                                  *
+ * This program is distributed in the hope that it will be useful,  *
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of   *
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the    *
+ * GNU General Public License for more details.                     *
+ *                                                                  *
+ * You should have received a copy of the GNU General Public License*
+ * along with this program; if not, you can retrieve it from        *
+ * http://www.gnu.org/licenses/old-licenses/gpl-2.0.html            *
+ * or contact:                                                      *
+ *                                                                  *
+ * Free Software Foundation           Voice:  +1-617-542-5942       *
+ * 51 Franklin Street, Fifth Floor    Fax:    +1-617-542-2652       *
+ * Boston, MA  02110-1301,  USA       gnu@gnu.org                   *
+ ********************************************************************/
+
+#include "../kvp-value.hpp"
+#include "../guid.h"
+#include "../kvp_frame.hpp"
+#include "../gnc-date.h"
+#include <memory>
+#include <gtest/gtest.h>
+
+TEST (KvpValueTest, Replace_Frame)
+{
+    auto f1 = new KvpFrameImpl;
+    std::unique_ptr<KvpValueImpl> v1 {new KvpValueImpl {f1}};
+    auto f2 = new KvpFrameImpl;
+    EXPECT_EQ (f1, v1->replace_frame_nc (f2));
+    v1->set (5.2);
+    /*f1 and f2 should be deleted now*/
+    f1 = new KvpFrameImpl;
+    EXPECT_EQ (nullptr, v1->replace_frame_nc (f1));
+    delete f1;
+}
+
+TEST (KvpValueTest, Equality)
+{
+    std::unique_ptr<KvpValueImpl> v1 {new KvpValueImpl { (int64_t)1}};
+    std::unique_ptr<KvpValueImpl> v2 {new KvpValueImpl { (int64_t)2}};
+    EXPECT_LT (compare (*v1, *v2), 0);
+    // This is deleted in the kvpvalue destructor!
+    auto guid = guid_new ();
+    v1 = std::unique_ptr<KvpValueImpl> {new KvpValueImpl {guid}};
+    //this guid is also deleted in kvp value destructor.
+    v2 = std::unique_ptr<KvpValueImpl> {new KvpValueImpl {guid_copy (guid)}};
+    EXPECT_EQ (compare (*v1, *v2), 0);
+
+    v1 = std::unique_ptr<KvpValueImpl> {new KvpValueImpl {timespec_now ()}};
+    v2 = std::unique_ptr<KvpValueImpl> {new KvpValueImpl {*v1}};
+    EXPECT_EQ (compare (*v1, *v2), 0);
+}
+
+TEST (KvpValueTest, Add)
+{
+    auto v3 = new KvpValueImpl {timespec_now ()};
+    auto v4 = new KvpValueImpl {*v3};
+    auto new_one = v3->add (v4);
+    EXPECT_NE (new_one, v3);
+    EXPECT_EQ (new_one->get_type (), KvpValueType::KVP_TYPE_GLIST);
+    EXPECT_NE (new_one->get<GList*> (), nullptr);
+    /* also deletes v3 and v4 because they're "in" new_one */
+    delete new_one;
+}
+
+TEST (KvpValueTest, Copy)
+{
+    std::unique_ptr<KvpValueImpl> v1 {new KvpValueImpl {5.2}};
+    std::unique_ptr<KvpValueImpl> v2 {new KvpValueImpl {*v1}};
+    EXPECT_EQ (compare (*v1, *v2), 0);
+
+    auto guid = guid_new ();
+    v1 = std::unique_ptr<KvpValueImpl> {new KvpValueImpl {guid}};
+    v2 = std::unique_ptr<KvpValueImpl> {new KvpValueImpl {*v1}};
+    EXPECT_EQ (compare (*v1, *v2), 0);
+
+    v1 = std::unique_ptr<KvpValueImpl> {new KvpValueImpl {guid}};
+    v2 = std::unique_ptr<KvpValueImpl> {new KvpValueImpl {*v1}};
+    /*This should delete the guid*/
+    v1->set(5.2);
+    EXPECT_NE (compare (*v1, *v2), 0);
+}