Don't use g_list_append unnecessarily

This commit is contained in:
Christopher Lam 2021-02-09 23:41:17 +08:00
parent 449c298fdd
commit c20a588e0f
3 changed files with 6 additions and 6 deletions

View File

@ -470,8 +470,8 @@ gnc_ui_update_commodity_picker (GtkWidget *cbwe,
for (iterator = commodities; iterator; iterator = iterator->next)
{
commodity_items =
g_list_append(commodity_items,
(gpointer) gnc_commodity_get_printname(iterator->data));
g_list_prepend (commodity_items,
(gpointer) gnc_commodity_get_printname(iterator->data));
}
g_list_free(commodities);

View File

@ -305,13 +305,13 @@ gnc_prices_dialog_get_commodities (GtkTreeView *view)
if (gtk_tree_model_get_iter (model, &iter, row->data))
{
gtk_tree_model_get (model, &iter, PRICED_COMM, &comm, -1);
comm_list = g_list_append (comm_list, comm);
comm_list = g_list_prepend (comm_list, comm);
}
}
g_list_foreach (list, (GFunc) gtk_tree_path_free, NULL);
g_list_free (list);
return comm_list;
return g_list_reverse (comm_list);
}
static void

View File

@ -982,11 +982,11 @@ GSList * qof_query_get_term_type (QofQuery *q, QofQueryParamList *term_param)
{
QofQueryTerm *qt = static_cast<QofQueryTerm*>(_and_->data);
if (!param_list_cmp (term_param, qt->param_list))
results = g_slist_append(results, qt->pdata);
results = g_slist_prepend (results, qt->pdata);
}
}
return results;
return g_slist_reverse (results);
}
void qof_query_destroy (QofQuery *q)