IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Test rounded values, but don't store them, to minimize jitter in prices.

Browse Source
This commit is contained in:
John Ralls 2016-03-11 15:10:12 -08:00
parent e26e598cdc
commit c4ce44df64
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/gnome-utils/dialog-transfer.c
View File

@ -1586,15 +1586,21 @@ update_price(XferDialog *xferData, PriceReq *pr)
gnc_commodity *to = xferData->to_commodity; gnc_commodity *to = xferData->to_commodity;
gnc_numeric value = gnc_amount_edit_get_amount(GNC_AMOUNT_EDIT(xferData->price_edit)); gnc_numeric value = gnc_amount_edit_get_amount(GNC_AMOUNT_EDIT(xferData->price_edit));
gnc_numeric price_value = gnc_price_get_value(pr->price); gnc_numeric price_value = gnc_price_get_value(pr->price);
gnc_numeric rounded_pr_value = round_price(pr->from, pr->to, price_value);
gnc_numeric rounded_value;
if (gnc_numeric_equal(pr->reverse ? gnc_numeric_invert(value) : value,
price_value))
if (gnc_price_get_source(pr->price) < xferData->price_source) if (gnc_price_get_source(pr->price) < xferData->price_source)
{ {
PINFO("Existing price is preferred, so won't supersede."); PINFO("Existing price is preferred, so won't supersede.");
gnc_price_unref (pr->price); gnc_price_unref (pr->price);
return; return;
} }
if (pr->reverse)
value = swap_commodities(&from, &to, value);
/* Test the rounded values for equality to minimize price-dithering. */
rounded_value = round_price(from, to, value);
if (gnc_numeric_equal(rounded_value, rounded_pr_value))
{ {
PINFO("Same price for %s in %s", PINFO("Same price for %s in %s",
gnc_commodity_get_mnemonic(pr->from), gnc_commodity_get_mnemonic(pr->from),
@ -1605,9 +1611,6 @@ update_price(XferDialog *xferData, PriceReq *pr)
gnc_price_begin_edit (pr->price); gnc_price_begin_edit (pr->price);
gnc_price_set_time (pr->price, pr->ts); gnc_price_set_time (pr->price, pr->ts);
gnc_price_set_typestr(pr->price, xferData->price_type); gnc_price_set_typestr(pr->price, xferData->price_type);
if (pr->reverse)
gnc_price_set_value (pr->price, gnc_numeric_invert(value));
else
gnc_price_set_value (pr->price, value); gnc_price_set_value (pr->price, value);
gnc_price_commit_edit (pr->price); gnc_price_commit_edit (pr->price);
PINFO("Updated price: 1 %s = %f %s", PINFO("Updated price: 1 %s = %f %s",