From c549e203cba837584059984b3e199f3929590156 Mon Sep 17 00:00:00 2001 From: John Ralls Date: Mon, 23 Dec 2024 12:59:11 -0800 Subject: [PATCH] Bug 799449 - Save As... sequence from SQL to XML format does not... clear lock on the origin SQL book. GncDbiSqlConnection::unlock_database function errored out if the last dbi interaction resulted in an error, even if it was a harmless index out of range. Ignore index out of range errors. --- libgnucash/backend/dbi/gnc-dbisqlconnection.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libgnucash/backend/dbi/gnc-dbisqlconnection.cpp b/libgnucash/backend/dbi/gnc-dbisqlconnection.cpp index 7b4e85fdb6..d1b8626a2a 100644 --- a/libgnucash/backend/dbi/gnc-dbisqlconnection.cpp +++ b/libgnucash/backend/dbi/gnc-dbisqlconnection.cpp @@ -173,7 +173,8 @@ GncDbiSqlConnection::unlock_database () { if (m_conn == nullptr) return; if (m_readonly) return; - g_return_if_fail (dbi_conn_error (m_conn, nullptr) == 0); + auto dbi_error{dbi_conn_error (m_conn, nullptr)}; + g_return_if_fail (dbi_error == DBI_ERROR_NONE || dbi_error == DBI_ERROR_BADIDX); auto tables = m_provider->get_table_list (m_conn, lock_table); if (tables.empty())