IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-16 18:25:11 -06:00
Code Issues Packages Projects Releases Wiki Activity

Add ability for no-autocompletion option in split register, use in SX editor to prevent bug.

Browse Source 
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@12086 57a11ea4-9604-0410-9ed3-97b8803252fd
This commit is contained in:
Joshua Sled 2005-12-03 19:41:53 +00:00
parent 1a05402127
commit c68f43b389
6 changed files with 38 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ChangeLog
View File

@ -4,6 +4,15 @@
updating the translation template. Rename the rule for
auto-generation of ChangeLog.svn from svn to "ChangeLog.svn".
2005-12-03 Joshua Sled <jsled@asynchronous.org>
* split-register-control.c (gnc_split_register_auto_completion):
Fail fast if no auto-complete requested.
* split-register.c (gnc_split_register_set_auto_complete): Add new
configuration option to turn off auto-completion.
* dialog-scheduledxaction.c (schedXact_editor_create_ledger): Turn
off auto-complete on the SX template register.
2005-12-03 Joshua Sled <jsled@asynchronous.org>
* GNOME2_STATUS: remove GOG-porting notes, spelling fixes.

38
GNOME2_STATUS
View File

@ -13,10 +13,6 @@ and will disappear in a future release. Its important to get this
release out the door and not stall it until all the deprecated
functionality has been removed.
+--------------------------------------+
| Last sync with HEAD on 2005-10-31 |
+--------------------------------------+
========================================
DONE
========================================
@ -38,7 +34,7 @@ Stock Split Dialog
+-----
| Can someone who comes across this note and wants to help please go
| through 1.8.9 and create a list of stuff missing from 2.0?
| through 1.8.x and create a list of stuff missing from 2.0?
+------------
========================================
@ -59,23 +55,9 @@ Resources
- Printing text reports works.
- Printing pie/bar charts fails.
- Startup CRITICAL errors...
[jsled@phoenix:~/stuff/proj/gnucash/src-g2/gnucash]$ /opt/gnc-g2-unstable/bin/gnucash
(gnucash:7823): GLib-GObject-CRITICAL **: file gvaluetypes.c: line 741 (g_value_set_string): assertion `G_VALUE_HOLDS_STRING (value)' failed
(gnucash:7823): GLib-GObject-CRITICAL **: file gobject.c: line 1239 (g_object_set_property): assertion `G_IS_VALUE (value)' failed
(gnucash:7823): GLib-GObject-CRITICAL **: file gvalue.c: line 149 (g_value_unset): assertion `G_IS_VALUE (value)' failed
(gnucash:7823): GLib-GObject-CRITICAL **: file gvaluetypes.c: line 741 (g_value_set_string): assertion `G_VALUE_HOLDS_STRING (value)' failed
(gnucash:7823): GLib-GObject-CRITICAL **: file gobject.c: line 1239 (g_object_set_property): assertion `G_IS_VALUE (value)' failed
(gnucash:7823): GLib-GObject-CRITICAL **: file gvalue.c: line 149 (g_value_unset): assertion `G_IS_VALUE (value)' failed
(gnucash:7823): GLib-GObject-CRITICAL **: file gvaluetypes.c: line 741 (g_value_set_string): assertion `G_VALUE_HOLDS_STRING (value)' failed
(gnucash:7823): GLib-GObject-CRITICAL **: file gobject.c: line 1239 (g_object_set_property): assertion `G_IS_VALUE (value)' failed
(gnucash:7823): GLib-GObject-CRITICAL **: file gvalue.c: line 149 (g_value_unset): assertion `G_IS_VALUE (value)' failed
Use of deprecated SAXv1 function getLineNumber
- Open pages are no longer open after reopening file.
- Account tree, register and report pages are restored.
- Budget and busines pages are not restored.
- Budget and business pages are not restored.
- Trying to reopen a multi-column report spits lots of
warning. Trying to edit that pages options crashes gnucash.
@ -109,7 +91,6 @@ Resources
- HBCI - Transaction templates eventually need to be converted from a GTK_CLIST
to a GTK_TREE_VIEW. Currently working as a GtkClist.
- Budgeting
- Budget Report
@ -188,10 +169,6 @@ Resources
- SX Editor
- When tabbing from memo to account on the second split with the same
name as the first, the account will be auto-populated with a GUID
(instead of an account name), but not a valid one.
- Template-register Cut/Copy/Paste not connected.
- Template-register View > {Basic, Auto-Split} options have no effect.
@ -199,10 +176,6 @@ Resources
- Open SX Editor, close it; open Register Preferences, change "Draw
{horiz,vert} lines" => crash.
- Entering a value (e.g. '20.00') without entering an account or a memo for
the first split causes everything else entered so far to be reset when
tabbing to the second split.
========================================
ENHANCEMENTS
========================================
@ -234,3 +207,10 @@ Resources
and then remove the "Close" button from the toolbar. Then we can also
decide if we want to allow a user to 'close' the account tree.
- Scheduled Transactions
- Entering a value (e.g. '20.00') without entering an account or a memo for
the first split causes everything else entered so far to be reset when
tabbing to the second split.

1
src/gnome/dialog-scheduledxaction.c
View File

@ -1604,6 +1604,7 @@ schedXact_editor_create_ledger( SchedXactionEditorDialog *sxed )
gnc_split_register_config(splitreg,
splitreg->type, splitreg->style,
FALSE);
gnc_split_register_set_auto_complete(splitreg, FALSE);
/* don't show present/future divider [by definition, not necessary] */
gnc_split_register_show_present_divider( splitreg, FALSE );

2
src/register/ledger-core/split-register-control.c
View File

@ -623,6 +623,8 @@ gnc_split_register_auto_completion (SplitRegister *reg,
BasicCell *cell;
Split *split;
g_return_val_if_fail(reg->do_auto_complete, FALSE);
blank_split = xaccSplitLookup (&info->blank_split_guid,
gnc_get_current_book ());
blank_trans = xaccSplitGetParent (blank_split);

12
src/register/ledger-core/split-register.c
View File

@ -2186,6 +2186,7 @@ gnc_split_register_init (SplitRegister *reg,
SplitRegisterType type,
SplitRegisterStyle style,
gboolean use_double_line,
gboolean do_auto_complete,
gboolean is_template)
{
TableLayout *layout;
@ -2203,6 +2204,7 @@ gnc_split_register_init (SplitRegister *reg,
reg->type = type;
reg->style = style;
reg->use_double_line = use_double_line;
reg->do_auto_complete = do_auto_complete;
reg->is_template = is_template;
layout = gnc_split_register_layout_new (reg);
@ -2261,6 +2263,7 @@ gnc_split_register_new (SplitRegisterType type,
gboolean is_template)
{
SplitRegister * reg;
gboolean default_do_auto_complete = TRUE;
reg = g_new0 (SplitRegister, 1);
@ -2271,6 +2274,7 @@ gnc_split_register_new (SplitRegisterType type,
type,
style,
use_double_line,
default_do_auto_complete,
is_template);
return reg;
@ -2313,6 +2317,14 @@ gnc_split_register_config (SplitRegister *reg,
gnc_table_realize_gui (reg->table);
}
void
gnc_split_register_set_auto_complete(SplitRegister *reg,
gboolean do_auto_complete)
{
g_return_if_fail(reg);
reg->do_auto_complete = do_auto_complete;
}
static void
gnc_split_register_destroy_info (SplitRegister *reg)
{

5
src/register/ledger-core/split-register.h
View File

@ -245,6 +245,7 @@ struct split_register
gboolean use_double_line;
gboolean is_template;
gboolean do_auto_complete;
SRInfo * sr_info; /**< \internal private data; outsiders should not access this */
};
@ -267,6 +268,10 @@ void gnc_split_register_config (SplitRegister *reg,
SplitRegisterStyle style,
gboolean use_double_line);
/** Change the auto-completion behavior. **/
void gnc_split_register_set_auto_complete(SplitRegister *reg,
gboolean do_auto_complete);
/** Destroy the split register. */
void gnc_split_register_destroy (SplitRegister *reg);