IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

-- reject voided transactions in cap-gains caluclations;

Browse Source 
-- improve diagnostic error messages


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@10147 57a11ea4-9604-0410-9ed3-97b8803252fd
This commit is contained in:
Linas Vepstas 2004-07-03 18:57:31 +00:00
parent 75fbd13b64
commit cc663f2098
1 changed files with 32 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/engine/cap-gains.c
View File

@ -367,6 +367,27 @@ xaccSplitAssignToLot (Split *split, GNCLot *lot)
/* If this split already belongs to a lot, we are done. */ /* If this split already belongs to a lot, we are done. */
if (split->lot) return NULL; if (split->lot) return NULL;
/* Anomolous situation; except for voided transactions,
* we don't expect to see splits with no amount ..
* unless they're gains splits, and we shouldn't see those.
*/
if (gnc_numeric_zero_p (split->amount))
{
if (xaccTransGetVoidStatus(split->parent)) return NULL;
PWARN ("split with zero amount; value=%s gflag=%x gsplit=%p",
gnc_numeric_to_string (split->amount),
split->gains,
split->gains_split);
if (split->gains_split)
{
PWARN ("gains amt=%s value=%s",
gnc_numeric_to_string (split->gains_split->amount),
gnc_numeric_to_string (split->gains_split->value));
}
return NULL;
}
/* If the lot is closed, we can't add anything to it */ /* If the lot is closed, we can't add anything to it */
baln = gnc_lot_get_balance (lot); baln = gnc_lot_get_balance (lot);
if (gnc_lot_is_closed (lot)) return split; if (gnc_lot_is_closed (lot)) return split;
@ -467,6 +488,11 @@ xaccSplitAssignToLot (Split *split, GNCLot *lot)
gnc_numeric_to_string(amt_tot)); gnc_numeric_to_string(amt_tot));
} }
if (gnc_numeric_zero_p(val_a) || gnc_numeric_zero_p(val_b))
{
PERR ("Failed to split into two!");
}
PINFO ("split value is = %s = %s + %s", PINFO ("split value is = %s = %s + %s",
gnc_numeric_to_string(val_tot), gnc_numeric_to_string(val_tot),
gnc_numeric_to_string(val_a), gnc_numeric_to_string(val_a),
@ -743,7 +769,9 @@ xaccSplitComputeCapGains(Split *split, Account *gain_acc)
if (0 > gnc_numeric_compare (gnc_numeric_abs(opening_amount), if (0 > gnc_numeric_compare (gnc_numeric_abs(opening_amount),
gnc_numeric_abs(split->amount))) gnc_numeric_abs(split->amount)))
{ {
PERR ("Malformed Lot! (too thin!)"); PERR ("Malformed Lot! (too thin!) opening amt=%s split amt=%s ",
gnc_numeric_to_string (opening_amount),
gnc_numeric_to_string (split->amount));
return; return;
} }
if ( (gnc_numeric_negative_p(opening_amount) || if ( (gnc_numeric_negative_p(opening_amount) ||
@ -751,7 +779,9 @@ xaccSplitComputeCapGains(Split *split, Account *gain_acc)
(gnc_numeric_positive_p(opening_amount) || (gnc_numeric_positive_p(opening_amount) ||
gnc_numeric_negative_p(split->amount))) gnc_numeric_negative_p(split->amount)))
{ {
PERR ("Malformed Lot! (too fat!)"); PERR ("Malformed Lot! (too fat!) opening amt=%s split amt=%s ",
gnc_numeric_to_string (opening_amount),
gnc_numeric_to_string (split->amount));
return; return;
} }