IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2024-11-26 02:40:43 -06:00
Code Issues Packages Projects Releases Wiki Activity

Calling sigfigs_denom with a zero crashes due to a divide by zero.

Browse Source
This commit is contained in:
Mike Alexander 2017-04-04 01:58:32 -04:00
parent 6933ab765d
commit cdc94c7131
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/libqof/qof/gnc-numeric.cpp
View File

@ -280,6 +280,9 @@ GncNumeric::prepare_conversion(int64_t new_denom) const
int64_t
GncNumeric::sigfigs_denom(unsigned figs) const noexcept
{
if (m_num == 0)
return 1;
int64_t num_abs{std::abs(m_num)};
bool not_frac = num_abs > m_den;
int64_t val{ not_frac ? num_abs / m_den : m_den / num_abs };

3
src/libqof/qof/gnc-rational.cpp
View File

@ -159,6 +159,9 @@ GncRational::prepare_conversion (GncInt128 new_denom) const
GncInt128
GncRational::sigfigs_denom(unsigned figs) const noexcept
{
if (m_num == 0)
return 1;
auto num_abs = m_num.abs();
bool not_frac = num_abs > m_den;
int64_t val{ not_frac ? num_abs / m_den : m_den / num_abs };