From d4bbede08f171211fd1dd3d6018c8f95dca86f34 Mon Sep 17 00:00:00 2001 From: Mike Alexander Date: Tue, 17 Nov 2015 02:25:37 -0500 Subject: [PATCH] Set val_imbalance in gnc_transaction_balance_trading. When the code was refactored in 61973a8 the return value from the new function gnc_transaction_get_commodity_imbalance was ignored. This had the effect of using an uninitialized variable to set the value in a new trading account split that is not for the transaction's currency. That means that multicommodity transactions created with this bug and trading accounts on will not be balanced. --- src/engine/Scrub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/engine/Scrub.c b/src/engine/Scrub.c index c82b3530d9..dc22b20bad 100644 --- a/src/engine/Scrub.c +++ b/src/engine/Scrub.c @@ -673,7 +673,7 @@ gnc_transaction_balance_trading (Transaction *trans, Account *root) if (! gnc_commodity_equal (txn_curr, commodity)) { - gnc_transaction_get_commodity_imbalance (trans, commodity); + val_imbalance = gnc_transaction_get_commodity_imbalance (trans, commodity); } xaccTransBeginEdit (trans);