IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Make a constant for std::numeric_limits<std::size_t>max().

Browse Source 
Improves readability.
This commit is contained in:
John Ralls 2019-12-05 17:47:30 -08:00
parent 826d75af16
commit d7a2a0ffff
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
libgnucash/app-utils/gnc-option.hpp
View File

@ -178,6 +178,8 @@ private:
GncOptionUIType m_ui_type; GncOptionUIType m_ui_type;
}; };
auto constexpr size_t_max = std::numeric_limits<std::size_t>::max();
template <typename ValueType> template <typename ValueType>
class GncOptionValue : public OptionClassifier, public OptionUIItem class GncOptionValue : public OptionClassifier, public OptionUIItem
{ {
@ -496,7 +498,7 @@ public:
if (value) if (value)
{ {
if (auto index = find_key(value); if (auto index = find_key(value);
index != std::numeric_limits<std::size_t>::max()) index != size_t_max)
{ {
m_value = index; m_value = index;
m_default_value = index; m_default_value = index;
@ -520,13 +522,13 @@ public:
bool validate(const std::string& value) const noexcept bool validate(const std::string& value) const noexcept
{ {
auto index = find_key(value); auto index = find_key(value);
return index != std::numeric_limits<std::size_t>::max(); return index != size_t_max;
} }
void set_value(const std::string& value) void set_value(const std::string& value)
{ {
auto index = find_key(value); auto index = find_key(value);
if (index != std::numeric_limits<std::size_t>::max()) if (index != size_t_max)
m_value = index; m_value = index;
else else
throw std::invalid_argument("Value not a valid choice."); throw std::invalid_argument("Value not a valid choice.");
@ -562,7 +564,7 @@ private:
if (iter != m_choices.end()) if (iter != m_choices.end())
return iter - m_choices.begin(); return iter - m_choices.begin();
else else
return std::numeric_limits<std::size_t>::max(); return size_t_max;
} }
std::size_t m_value; std::size_t m_value;
@ -956,7 +958,7 @@ public:
GncOptionMultichoiceValue>) GncOptionMultichoiceValue>)
return option.num_permissible_values(); return option.num_permissible_values();
else else
return std::numeric_limits<std::size_t>::max(); return size_t_max;
}, m_option); }, m_option);
} }
@ -967,7 +969,7 @@ public:
GncOptionMultichoiceValue>) GncOptionMultichoiceValue>)
return option.permissible_value_index(value); return option.permissible_value_index(value);
else else
return std::numeric_limits<std::size_t>::max();; return size_t_max;;
}, m_option); }, m_option);
} }