From dd28f4ed4f95d1630180a9a836e0ae5bcde8d1e7 Mon Sep 17 00:00:00 2001 From: Robert Fewell <14uBobIT@gmail.com> Date: Sat, 14 Apr 2018 03:23:57 +0100 Subject: [PATCH] Remove the set transient parent setting for Reconcile window The Reconcile option is already a window so it is not necessary to set this value which allows the jump to transaction to work properly. --- gnucash/gnome/window-reconcile.c | 11 ++++------- gnucash/gnome/window-reconcile.h | 6 ++---- gnucash/import-export/aqb/gnc-ab-utils.c | 2 +- 3 files changed, 7 insertions(+), 12 deletions(-) diff --git a/gnucash/gnome/window-reconcile.c b/gnucash/gnome/window-reconcile.c index 2581d50da7..5c849bc01b 100644 --- a/gnucash/gnome/window-reconcile.c +++ b/gnucash/gnome/window-reconcile.c @@ -1662,7 +1662,7 @@ recnWindow (GtkWidget *parent, Account *account) enable_subaccounts)) return NULL; - return recnWindowWithBalance (parent, account, new_ending, statement_date); + return recnWindowWithBalance (account, new_ending, statement_date); } @@ -1682,15 +1682,14 @@ recnWindow_add_widget (GtkUIManager *merge, * Opens up the window to reconcile an account, but with ending * balance and statement date already given. * - * Args: parent - The parent widget of the new window - * account - The account to reconcile + * Args: account - The account to reconcile * new_ending - The amount for ending balance * statement_date - The date of the statement * Return: recnData - the instance of this RecnWindow \********************************************************************/ RecnWindow * -recnWindowWithBalance (GtkWidget *parent, Account *account, - gnc_numeric new_ending, time64 statement_date) +recnWindowWithBalance (Account *account, gnc_numeric new_ending, + time64 statement_date) { RecnWindow *recnData; GtkWidget *statusbar; @@ -1924,8 +1923,6 @@ recnWindowWithBalance (GtkWidget *parent, Account *account, /* Allow resize */ gtk_window_set_resizable(GTK_WINDOW(recnData->window), TRUE); - gtk_window_set_transient_for(GTK_WINDOW(recnData->window), - GTK_WINDOW (parent)); gtk_widget_show_all(recnData->window); gnc_reconcile_window_set_titles(recnData); diff --git a/gnucash/gnome/window-reconcile.h b/gnucash/gnome/window-reconcile.h index 26dc8add50..0516140d8b 100644 --- a/gnucash/gnome/window-reconcile.h +++ b/gnucash/gnome/window-reconcile.h @@ -52,14 +52,12 @@ RecnWindow *recnWindow (GtkWidget *parent, Account *account); * Opens up the window to reconcile an account, but with ending * balance and statement date already given. * - * Args: parent - The parent widget of the new window - * account - The account to reconcile + * Args: account - The account to reconcile * new_ending - The amount for ending balance * statement_date - The date of the statement * Return: recnData - the instance of this RecnWindow \********************************************************************/ -RecnWindow *recnWindowWithBalance (GtkWidget *parent, - Account *account, +RecnWindow *recnWindowWithBalance (Account *account, gnc_numeric new_ending, time64 statement_date); diff --git a/gnucash/import-export/aqb/gnc-ab-utils.c b/gnucash/import-export/aqb/gnc-ab-utils.c index 549fd28045..03d65397db 100644 --- a/gnucash/import-export/aqb/gnc-ab-utils.c +++ b/gnucash/import-export/aqb/gnc-ab-utils.c @@ -1060,7 +1060,7 @@ bal_accountinfo_cb(AB_IMEXPORTER_ACCOUNTINFO *element, gpointer user_data) /* Show reconciliation window */ if (show_recn_window) - recnWindowWithBalance(data->parent, gnc_acc, value, booked_tt); + recnWindowWithBalance(gnc_acc, value, booked_tt); return NULL; }