From e26e598cdc8f635d9a7700e8732b401d619e3dd5 Mon Sep 17 00:00:00 2001 From: John Ralls Date: Fri, 11 Mar 2016 15:08:11 -0800 Subject: [PATCH] Check price_source precedence first to save computation. --- src/gnome-utils/dialog-transfer.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gnome-utils/dialog-transfer.c b/src/gnome-utils/dialog-transfer.c index 66d148aecc..5e0b1ec7cb 100644 --- a/src/gnome-utils/dialog-transfer.c +++ b/src/gnome-utils/dialog-transfer.c @@ -1589,6 +1589,12 @@ update_price(XferDialog *xferData, PriceReq *pr) if (gnc_numeric_equal(pr->reverse ? gnc_numeric_invert(value) : value, price_value)) + if (gnc_price_get_source(pr->price) < xferData->price_source) + { + PINFO("Existing price is preferred, so won't supersede."); + gnc_price_unref (pr->price); + return; + } { PINFO("Same price for %s in %s", gnc_commodity_get_mnemonic(pr->from), @@ -1596,12 +1602,6 @@ update_price(XferDialog *xferData, PriceReq *pr) gnc_price_unref (pr->price); return; } - if (gnc_price_get_source(pr->price) < xferData->price_source) - { - PINFO("Existing price is preferred, so won't supersede."); - gnc_price_unref (pr->price); - return; - } gnc_price_begin_edit (pr->price); gnc_price_set_time (pr->price, pr->ts); gnc_price_set_typestr(pr->price, xferData->price_type);